Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepalived >=2.0.19 does not build with --disable-lvs and --disable-libipset-dynamic #1516

Closed
stintel opened this issue Mar 4, 2020 · 1 comment
Closed

keepalived >=2.0.19 does not build with --disable-lvs and --disable-libipset-dynamic #1516

stintel opened this issue Mar 4, 2020 · 1 comment

Comments

@stintel
Copy link
Contributor

stintel commented Mar 4, 2020

Describe the bug
keepalived >=2.0.19 does not build with --disable-lvs and --disable-libipset-dynamic

To Reproduce
./configure --disable-lvs --disable-libipset-dynamic
make

Expected behavior
keepalived builds

Observed behavior

make[2]: Entering directory '/home/stijn/Development/keepalived/keepalived'
  CCLD     keepalived
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: vrrp/libvrrp.a(vrrp_ipset.o): in function `ipset_initialise':
/home/stijn/Development/keepalived/keepalived/vrrp/vrrp_ipset.c:324: undefined reference to `keepalived_modprobe'
collect2: error: ld returned 1 exit status

Keepalived version
N/A

Distro (please complete the following information):

  • Name: OpenWrt
  • Version: master
  • Architecture: x86/64, mips64

Details of any containerisation or hosted service (e.g. AWS)
N/A

Configuration file:
N/A

Notify and track scripts
N/A

System Log entries
N/A

Did keepalived coredump?
N/A

Additional context
N/A
@stintel stintel mentioned this issue Mar 4, 2020
Closed
pqarmitage added a commit to pqarmitage/keepalived that referenced this issue Mar 4, 2020
@pqarmitage
Fix building with --disable-libipvs-dynamic
42c020a 
Issue acassen#1516 reported by the OpenWRT project identified that
keepalived_modprobe() was not defined if --disable-libipvs-dynamic
was specified.

Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
@pqarmitage
Copy link
Collaborator

Many thanks for reporting this. Commit 42c020a resolves the issue (it was checking for an incorrect define generated by configure).

The patch appears to apply cleanly to v2.0.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stintel @pqarmitage and others