Permalink
Browse files

Small tweak to avoid having 'Unknown' twice.

New version number.
  • Loading branch information...
1 parent 5e4712a commit 474870a3d7af80e109e3fd5ab328039c259e6821 @acaudwell committed Jul 31, 2016
Showing with 8 additions and 5 deletions.
  1. +3 −0 ChangeLog
  2. +1 −1 configure.ac
  3. +3 −3 src/formats/svn.cpp
  4. +1 −1 src/gource_settings.h
View
3 ChangeLog
@@ -1,3 +1,6 @@
+0.45:
+ * Fixed crash when SVN log lacks author information (obarthel).
+
0.44:
* Fixed crash when taking a screenshot with an odd resolution.
* Fixed type deduction compilation error with newer versions of GCC.
View
2 configure.ac
@@ -3,7 +3,7 @@
AC_PREREQ(2.61)
-AC_INIT(Gource, 0.44, [acaudwell@gmail.com])
+AC_INIT(Gource, 0.45, [acaudwell@gmail.com])
AC_CONFIG_AUX_DIR([build-aux])
AC_CONFIG_SRCDIR([src/main.h])
AM_INIT_AUTOMAKE([dist-bzip2 foreign subdir-objects])
View
6 src/formats/svn.cpp
@@ -245,9 +245,9 @@ bool SVNCommitLog::parseCommit(RCommit& commit) {
TiXmlElement* authorE = leE->FirstChildElement("author");
if(authorE != 0) {
- // GetText() may return NULL, causing author instantiation to crash.
- std::string author(authorE->GetText() ? authorE->GetText() : "Unknown");
-
+ // GetText() may return NULL, causing author instantiation to crash.
+ std::string author;
+ if(authorE->GetText()) author = authorE->GetText();
if(author.empty()) author = "Unknown";
commit.username = author;
View
2 src/gource_settings.h
@@ -18,7 +18,7 @@
#ifndef GOURCE_SETTINGS_H
#define GOURCE_SETTINGS_H
-#define GOURCE_VERSION "0.44"
+#define GOURCE_VERSION "0.45"
#include "core/texture.h"
#include "core/settings.h"

0 comments on commit 474870a

Please sign in to comment.