Move the QRZ.COM credentials settings to the Integrations Page#985
Conversation
verified
verified |
accius
left a comment
There was a problem hiding this comment.
Good cleanup — addresses real user confusion about a setting that doesn't apply on the hosted site. The Save & Test button and both input fields now gate on isLocalInstall, which is exactly right, and the styling matches the surrounding Integrations sections cleanly.
One small nit: the Remove button (rendered when qrzStatus?.configured && qrzStatus.source !== 'env') is not gated on isLocalInstall, so on a non-local install where credentials were somehow already configured the Remove button is still active. Edge case (you can't reach the configure flow on hosted in the first place) but worth tightening if you spin up another commit.
Otherwise looks good, merging.
What does this PR do?
In spite of a clear notice that this is a setting only for folks running local servers people are still asking about how to set it.
This PR moves it to the Integrations settings panel and have it part of the Local-only settings and have it only settable if isLocalInstall is true.
Type of change
How to test
a. Verify the QRZ.COM Credentials settings do not appear on the Profiles Settings panel
b. Verify the QRZ.COM Credentials settings appear on the integrations page, the fields can be filled in and on completion of both text fields, the button becomes enabled.
a. Verify the QRZ.COM Credentials settings do not appear on the Profiles Settings panel
b. Verify that the QRZ.COm credentials settings cannot be edited
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included