Adam Conrad acconrad

Organizations

@CoachUp
@acconrad
Stagefright Vulnerability: No way to disable auto-downloading of MMS
acconrad opened pull request trulia/hologram#242
@acconrad
Include required HTML5 meta tags
1 commit with 2 additions and 0 deletions
@acconrad
  • @acconrad a5db594
    Include required HTML5 meta tags
@acconrad
Does not work for Rails 4.0.x projects utilizing the Asset Pipeline
acconrad commented on issue trulia/hologram#239
@acconrad

One thing I noticed was that I didn't want to worry about the Javascript-related things, so I just set my source: ./app/assets/stylesheets and that…

acconrad commented on pull request phoenixframework/phoenix#1016
@acconrad

@josevalim relating to my previous comment, how exactly could Phoenix.HTML dasherize that function - I'm not seeing anywhere in the code where that…

acconrad commented on pull request phoenixframework/phoenix#1016
@acconrad

@josevalim @chrismccord I've reverted the dasherization pipeline and just left it as is. I still think this function would be useful on the backend…

@acconrad
acconrad commented on pull request phoenixframework/phoenix#1016
@acconrad

good points re: dasherize. perhaps as a compromise, have the controller_name function within Phoenix.Controller and then Phoenix.HTML.controller_name

acconrad commented on pull request phoenixframework/phoenix#1016
@acconrad

@josevalim @chrismccord I've taken your suggestions and updated the code accordingly. For the sake of CSS conventions, I did a simply String.replace

@acconrad
  • @acconrad 80e9aef
    Use native resource_name function and dasherize output
acconrad commented on pull request phoenixframework/phoenix#1016
@acconrad

Thank you @josevalim ! I updated the code based on your comments to include the correct datatype returned.

@acconrad
  • @acconrad 0f1762b
    Add #controller_name method
@acconrad
Add #controller_name method to Phoenix.Controller
1 commit with 18 additions and 0 deletions
@acconrad
  • @acconrad 705fbab
    Add #controller_name method
acconrad commented on issue rwaldron/idiomatic.js#195
@acconrad

While I agree that it is clearer and easier to find missing commas, this is not a universally accepted axiom of the JS community. Plus, there are e…

@acconrad
@acconrad
Correct bundle command "exec"
1 commit with 5 additions and 5 deletions
@acconrad
  • @acconrad a3ff9eb
    Correct bundle command "exec"
acconrad commented on issue thoughtbot/paperclip#1696
@acconrad

@tute if it does end up working for you, it would be great to know exactly the code you have that got it working for you, and see if there was some…

acconrad commented on issue thoughtbot/paperclip#1696
@acconrad

@tute this is still an issue for us. I think one mistake I made was that I reported us using 2.7 of Paperclip but we are actually running over vers…