Afadnan/454/fix white space scroll #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afadnan
force-pushed
the
afadnan/454/fix-white-space-scroll
branch
2 times, most recently
from
275a146 to
5a011a4
Compare
Signed-off-by: Adnan Ashraf <af.adnan23@gmail.com>
afadnan
force-pushed
the
afadnan/454/fix-white-space-scroll
branch
from
5a011a4 to
f773658
Compare
Contributor
Author
|
Hey @jeromesimeon 👋 All checks have passed and the PR is ready for review. I’ve signed off the commit and resolved everything requested. Could you please review and approve it when you get a chance? Thanks a ton! |
mttrbrts
approved these changes
Apr 5, 2025
Member
mttrbrts
left a comment
mttrbrts
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Contributor
Author
|
Hey @mttrbrts , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix: Prevent White Space on Header/Footer Scroll
Closes
Summary
This PR fixes an issue where scrolling beyond the top or bottom of the webpage caused unwanted white space to appear at the header and footer.
Changes
Applied CSS fix to prevent excessive scrolling.
Ensured html, body height is properly set to 100%.
Removed unwanted overflow behavior.
Steps to Reproduce (Before Fix)
Open the website.
Scroll up beyond the top of the page.
Scroll down to the bottom and continue scrolling.
Notice the white space appearing above the header or below the footer.
Expected Behavior
Scrolling should naturally stop at the top and bottom of the page without revealing extra white space.
Fix Implementation
✅ Applied CSS to fix:
✅ Mention Video Below :
📌 Before (Bug Video) :
bug.mp4
📌 After (Fixed Video):
fixedbug.mp4
Related Issues
Issue #454 – [Bug] Scrolling Beyond Limits Causes White Space at Header/Footer
Author Checklist
✅ Ensured commit message follows AP format
✅ Provided a DCO sign-off using git commit -s
✅ Linked to related issue #454 in the PR description