Typescripting #23
Merged
Typescripting #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents}.tsx` instead of 'index.ts'
…o multiple components.
…optimization wish me good luck! ⻦
NoFishLikeIan
requested review from
nkint,
caesarsol,
marcofugaro,
lucamattiazzi and
glippi
marcofugaro
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal for typing the Accurat React Components.
On top of a preliminary typing (i.e. it probably needs more granular and correct use of types), a prop for
<Select/>component to override the default SVG dropdown error.Currently in order to not pass as
propSvgsomething like() => void, this is not ideal.