Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 4 (for chrome 17) #11

Merged
merged 1 commit into from Dec 6, 2011

Conversation

@Longer
Copy link

commented Nov 28, 2011

Hi. I fixed u issue 4 (and 8). But it maybe broke in previous version of chrome (need test it).

@aceat64

This comment has been minimized.

Copy link
Owner

commented Dec 6, 2011

Thank you. I'm testing this now, will merge if everything looks good.

aceat64 added a commit that referenced this pull request Dec 6, 2011
Merge pull request #11 from Longer/fix_bug
fix issue 4 (for chrome 17)

@aceat64 aceat64 merged commit 937a8d7 into aceat64:master Dec 6, 2011

@disfated

This comment has been minimized.

Copy link

commented Dec 6, 2011

why need bookmarks permission now?

@Longer

This comment has been minimized.

Copy link
Author

commented Dec 6, 2011

It's cause permission error as in https://github.com/aceat64/MailCheckerMinus/issues/8 but now if i remove it - nothing changing, very strange.

@Longer

This comment has been minimized.

Copy link
Author

commented Dec 6, 2011

I'm not yet update official version, but him write:
Error in event handler for 'undefined': TypeError: Cannot read property 'length' of undefined
at setupPageActionEvents (extensions/schema_generated_bindings.js:420:36)
at extensions/schema_generated_bindings.js:1063:5
at [object Object].dispatch (extensions/event.js:183:28)
at Object. (extensions/event.js:238:25)

extensions/schema_generated_bindings.js:184Uncaught Error: You do not have permission to use 'browserAction.setBadgeBackgroundColor'. Be sure to declare in your manifest what permissions you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.