New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add objects to all curators #2163
Conversation
Looks useful. It is fine now as an ACE_setting, but we need to be careful if we wanted to move this to the module. |
It's server side only, so |
class Extended_InitPost_EventHandlers { | ||
class AllVehicles { | ||
class ADDON { | ||
init = QUOTE(call FUNC(addObjectToCurator)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will error as the function uses params
and no argument is passed (params
doesn't handle a nil
input unless it's within an array).
Couldn't you use QFUNC though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using only a call will use the _this
from the scope where you use the call. QFUNC
is not an option since we need to call the function here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, of course, I assumed params wouldn't like that.
Also forgot this is string
, not code
. Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we can actually just make this serverInit
since it only need to run server side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. It's now changed 👍
Add objects from mission start and placed down by other curators to all curators.