Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objects to all curators #2163

Merged
merged 4 commits into from Aug 21, 2015
Merged

Add objects to all curators #2163

merged 4 commits into from Aug 21, 2015

Conversation

thojkooi
Copy link
Contributor

Add objects from mission start and placed down by other curators to all curators.

@thojkooi thojkooi added the kind/feature Release Notes: **ADDED:** label Aug 15, 2015
@thojkooi thojkooi added this to the 3.3.0 milestone Aug 15, 2015
@PabstMirror
Copy link
Contributor

Looks useful.

It is fine now as an ACE_setting, but we need to be careful if we wanted to move this to the module.
Module settings are read after unit init.

@thojkooi
Copy link
Contributor Author

It's server side only, so initPost should be fine? Otherwise we could check if moduleInit has been completed and if not, collect the units and execute the init function for them on the settingsInitalized event?

class Extended_InitPost_EventHandlers {
class AllVehicles {
class ADDON {
init = QUOTE(call FUNC(addObjectToCurator));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will error as the function uses params and no argument is passed (params doesn't handle a nil input unless it's within an array).

Couldn't you use QFUNC though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using only a call will use the _this from the scope where you use the call. QFUNC is not an option since we need to call the function here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, of course, I assumed params wouldn't like that.

Also forgot this is string, not code. Looks good 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we can actually just make this serverInit since it only need to run server side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. It's now changed 👍

kymckay added a commit that referenced this pull request Aug 21, 2015
@kymckay kymckay merged commit 5112bd9 into master Aug 21, 2015
@kymckay kymckay deleted the add-objects-to-curator branch August 21, 2015 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants