Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup reload launchers #3730

Merged
merged 3 commits into from May 4, 2016
Merged

Cleanup reload launchers #3730

merged 3 commits into from May 4, 2016

Conversation

PabstMirror
Copy link
Contributor

When merged this pull request will:

  • Cleanup reload launchers

Minor cleanup of params, and adds a fast exit for non supported weapons.

Todo: None of the launcher seem to have a good config for reload time and right now it's a 12 second progress bar which make this module pretty hard to use.

        magazineReloadTime = 12;

I can't really find any good config value for the real reload time (about 3 seconds), it might be linked to the reload animation??

@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Apr 28, 2016
@PabstMirror PabstMirror added this to the 3.6.0 milestone Apr 28, 2016
@commy2
Copy link
Contributor

commy2 commented Apr 28, 2016

Hand weapons don't use the magazineReloadTime property. Magazines are reloading instantly and only the animation is preventing the player from shooting.
It is used by vehicles mainly (they obviously have no reload animation)
I think the artificial delay from addWeaponItem is unrelated to this value and the delay is some kind of magic number in the engine. Don't know for sure though.

@PabstMirror
Copy link
Contributor Author

@commy2 Should we just hard code it to be 2-3 second then?
The receiver still has to wait for the ammo load.

@nicolasbadano
Copy link
Contributor

Should we just hard code it to be 2-3 second then?

👍

@commy2
Copy link
Contributor

commy2 commented Apr 28, 2016

For now. I don't see them fixing this bug anytime soon.

private "_reloadTime";
_reloadTime = getNumber (configFile >> "CfgWeapons" >> _weapon >> "magazineReloadTime");
// private _reloadTime = getNumber (configFile >> "CfgWeapons" >> _weapon >> "magazineReloadTime"); //Not a good config value, use a constant for now:
private _reloadTime = 2.5;
Copy link
Member

@bux bux May 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to introduce a new config value?
e.g. ACE_reloadlaunchers_buddyReloadTime
Maybe some launchers in the CUP or RHS weapon pack need more/less reload time?

@PabstMirror
Copy link
Contributor Author

Using @bux578 's suggestion, attempts to use QGVAR(buddyReloadTime) from weapon's config, else default to 2.5 seconds.

@commy2 commy2 merged commit 01cf551 into master May 4, 2016
@commy2 commy2 deleted the cleanupReloadLaunchers branch May 4, 2016 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants