Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to disable dogtags for factions, and disable for civilians #4539

Merged
merged 2 commits into from Oct 11, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Oct 10, 2016

When merged this pull request will:

  • adds function to disable dogtags for certain factions (e.g. rebels)
  • use it to disable dogtags for civilians

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 10, 2016
@commy2 commy2 added this to the 3.8.0 milestone Oct 10, 2016
@commy2 commy2 self-assigned this Oct 10, 2016
@@ -20,4 +20,7 @@ params ["_player", "_target"];

if (isNull _target) exitWith {false};

// check if disabled for faction
if ([GVAR(disabledFactions) getVariable faction _target] param [0, false]) exitWith {false};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only works now because we create the CBA namespace on mission start by calling the disableFactionDogtags. If we ever change that, this will break due to undefined variable.


params [["_faction", "", [""]]];

if (isNil QGVAR(disabledFactions)) then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be moved to postInit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to preInit

@thojkooi thojkooi merged commit 5d610cf into master Oct 11, 2016
@thojkooi thojkooi deleted the remove-dogtags-civilians branch October 11, 2016 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants