New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Activate Mine" action #6353

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
5 participants
@BaerMitUmlaut
Member

BaerMitUmlaut commented May 18, 2018

When merged this pull request will:

The only other way to hide the action would be adding another magazine to the GroundWeaponHolder. That's not really an option though since we'd have to continously check all of them on the map.

@commy2

commy2 approved these changes May 19, 2018

@PabstMirror PabstMirror merged commit 0ae93aa into master May 31, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@PabstMirror PabstMirror deleted the fix-mine-action branch May 31, 2018

@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.3 Jul 5, 2018

@madpat3

This comment has been minimized.

Contributor

madpat3 commented Aug 13, 2018

there is still a way to "vanilla-activate" the mine, right after you defused it (3.12.3).
so it's only partly fixed.

@commy2

This comment has been minimized.

Contributor

commy2 commented Aug 14, 2018

Wrong place for that post.

@madpat3

This comment has been minimized.

Contributor

madpat3 commented Aug 15, 2018

sorry, but i thought it was already merged, because of "PabstMirror modified the milestones: 3.13.0, 3.12.3 on 5 Jul".
so i thought it was already integrated into 3.12.3.

@bux

This comment has been minimized.

Member

bux commented Aug 16, 2018

This is a pull request that has been merged. Issues that might have arisen because of this pull request need to be placed in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment