New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ace_infoDisplayChanged will now trigger also for mods #6422

Merged
merged 2 commits into from Jul 13, 2018

Conversation

Projects
None yet
5 participants
@shukari
Contributor

shukari commented Jul 9, 2018

When merged this pull request will:

  • add 'RscUnitInfo' to Extended_DisplayLoad_EventHandlers
  • because 90% of the RscInGameUIs are use BIS_fnc_initDisplay with RscUnitInfo
  • instead of adding onLoad to all mod RscInGameUIs (example: RHS) it will go over the cba xeh

This works now perfect for my desire, the rhs jets now also get a limited UI by the Ace_UI addon. But i dont know what side effects this triggers.

shukari added some commits Jul 9, 2018

@jonpas

This comment has been minimized.

Member

jonpas commented Jul 9, 2018

There shouldn't be any side effects from ACE UI itself, only added support (which is great!), I am not sure about other things though, @commy2 ?

@jonpas jonpas added this to the 3.12.3 milestone Jul 9, 2018

@commy2

commy2 approved these changes Jul 9, 2018

Only one way to find out. :)

@dedmen

dedmen approved these changes Jul 10, 2018

@PabstMirror

This comment has been minimized.

Collaborator

PabstMirror commented Jul 13, 2018

uiNamespace setVariable [ARR_2('ACE_dlgSoldier', _this select 0)];
I can't find any use of the ACE_dlg* variables in our code, anyone know what they were for?

@jonpas

This comment has been minimized.

Member

jonpas commented Jul 13, 2018

Reads like "dialog" to me.

@PabstMirror

This comment has been minimized.

Collaborator

PabstMirror commented Jul 13, 2018

If it's just a old thing from AGM we might be able to drop the entire line, but it doesn't really hurt.

@PabstMirror PabstMirror merged commit 5fe8266 into acemod:master Jul 13, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@shukari shukari deleted the shukari:patch-7 branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment