New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in setupExplosive with CBA 3.8.0 #6476

Merged
merged 2 commits into from Jul 31, 2018

Conversation

Projects
None yet
3 participants
@alganthe
Contributor

alganthe commented Jul 28, 2018

When merged this pull request will:

  • getFov has a params check now, this function was passing args to it and causing an error.

Fixes #6475

Fix error in setupExplosive with CBA 3.8.0
getFov has a param check now, this function was passing args to it and causing an error.
@alganthe

This comment has been minimized.

Contributor

alganthe commented Jul 28, 2018

baer was faster

@alganthe alganthe closed this Jul 28, 2018

@alganthe

This comment has been minimized.

Contributor

alganthe commented Jul 29, 2018

This is an error anyways, and if params is reintroduced to getFov we might as well fix it.

@alganthe alganthe reopened this Jul 29, 2018

@alganthe

This comment has been minimized.

Contributor

alganthe commented Jul 29, 2018

That's correct.

@PabstMirror PabstMirror added this to the 3.12.3 milestone Jul 30, 2018

@PabstMirror PabstMirror merged commit 9f85a53 into acemod:master Jul 31, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alganthe alganthe deleted the alganthe:fixExploError branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment