[instrument_builder] database errors

[adamdaudrich]

While attempting to test the following test:

2. Edit DatabaseName and Question in the table directly and check if it sticks

While running php assign_missing_instruments confirm
I got the following error:

PHP Fatal error:  Uncaught PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'adaudrich_dev.adam_test_1' doesn't exist in /var/www/loris/php/libraries/Database.class.inc:415
Stack trace:
#0 /var/www/loris/php/libraries/Database.class.inc(415): PDOStatement->execute()
#1 /var/www/loris/php/libraries/Database.class.inc(232): Database->_realinsert()
#2 /var/www/loris/php/libraries/NDB_BVL_Battery.class.inc(232): Database->insert()
#3 /var/www/loris/tools/assign_missing_instruments.php(128): NDB_BVL_Battery->addInstrument()
#4 /var/www/loris/tools/assign_missing_instruments.php(153): populateVisitLabel()
#5 {main}
  thrown in /var/www/loris/php/libraries/Database.class.inc on line 415

My understanding is that table creation is not required for linst instruments.

I also ran php assign_missing_instruments V3 and got the following error:

PHP Fatal error:  Uncaught PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 's.CandiateID' in 'on clause' in /var/www/loris/src/Database/Query.php:46
Stack trace:
#0 /var/www/loris/src/Database/Query.php(46): PDOStatement->execute()
#1 /var/www/loris/tools/assign_missing_instruments.php(144): LORIS\Database\Query->getIterator()
#2 {main}
  thrown in /var/www/loris/src/Database/Query.php on line 46

Therefore:

3. Preview Instrument - NOT TESTED

4. Add Rules - NOT TESTED

5. Save Rules file - NOT TESTED

6. Validate Instrument (Does not save if there is a same QuestionName twice) NOT TESTED

[regisoc]

@adamdaudrich is it still happening?

[jeffersoncasimir]

Second error seems solved by: #9611

[jeffersoncasimir]

@adamdaudrich I think you can close this given that the second one is addressed by another PR and the first one seems specific to your environment (adam_test_1)

[adamdaudrich]

@jeffersoncasimir yes the errors i put up in this ISSUE were due to sql state. my bad!
hwoever, I still could not test linst instruments because of an Issue in NDB_BVL_Instrument.LINST
currently under review in PR #9667
so tests 3, 4, 5, 6 were not done because the instrument doesn't load. And I don't feel legit closing this issue before i can do that. It has been a complicated bug.

[adamdaudrich]

actually, on second thought, I will close - - the other issue is the more complicated one

[adamdaudrich]

Preview instrument = works
Validate instrument (duplicate question name triggers error) = works
Add Rules = works
Save Rules File = works