[score_instrument] test

[adamdaudrich]

https://github.com/aces/Loris/blob/d6eac834566fbb4c7ff1f302f1779cdd0f5c8d78/tools/data_integrity/score_instrument.php

While testing score_instrument, I selected the following instruments:

1. NDB_BVL_Instrument_aosi.class.inc
2. bmi.linst
3. NDB_BVL_Instrument_radiology_review.class.inc

USAGE:

score_instrument.php <test_name> one <candID> <sessionID> [inprogress] -> scores test only for this candidate

score_instrument.php <test_name> all [inprogress]   ->   scores test for all candidates meeting the necessary criteria

score_instrument.php all [inprogress]   ->   scores all instruments for all candidates meeting the necessary criteria

---

I have included outputs for the following commands.

php score_instrument.php aosi one 947103 2156

Running scoring for aosi
No records match the criteria returned for candidate (947103), timepoint (2156), instrument (aosi)!

https://github.com/aces/Loris/blob/d6eac834566fbb4c7ff1f302f1779cdd0f5c8d78/tools/data_integrity/score_instrument.php#L182

note: I used /instrument_list/?candID=947103&sessionID=2156

php score_instrument.php aosi all

Running scoring for aosi
No records for instrument aosi!
End

https://github.com/aces/Loris/blob/d6eac834566fbb4c7ff1f302f1779cdd0f5c8d78/tools/data_integrity/score_instrument.php#L188

php score_instrument bmi all

Running scoring for bmi
Start
PHP Fatal error:  Uncaught OutOfBoundsException: Invalid field Examiner for instrument  in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc:1412
Stack trace:
#0 /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc(1018): NDB_BVL_Instrument->getFieldValue()
#1 /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc(900): NDB_BVL_Instrument->_getExaminerNames()
#2 /var/www/loris/php/libraries/NDB_BVL_Instrument_LINST.class.inc(450): NDB_BVL_Instrument->_addMetadataFields()
#3 /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc(298): Loris\Behavioural\NDB_BVL_Instrument_LINST->loadInstrumentFile()
#4 /var/www/loris/tools/data_integrity/score_instrument.php(202): NDB_BVL_Instrument::factory()
#5 {main}
  thrown in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc on line 1412

php score_instrument.php radiology_review all

Candidate: 300001/V1/1:: (MTL001)
Candidate: 300002/V1/2:: (MTL002)
Candidate: 300003/V1/3:: (MTL003)
Candidate: 300006/V1/6:: (MTL006)
Candidate: 300007/V1/7:: (MTL007)
(etc )
End

php score_instrument.php radiology_review one 947103 2157

Running scoring for radiology_review
No records match the criteria returned for candidate (947103), timepoint (2157), instrument (radiology_review)!
End

[adamdaudrich]

I am not familiar with scoring (yet) - but - it seems that all are working - except the bmi test, due to a bug in NDB_BVL_Instrument.LINST throwing "examiner field" error in many different tools, including score_instrument. see PR #9667

[adamdaudrich]

@ridz1208 do you know the scoring tool? Would you look at this and tell me if it is working correctly in the test outputs included in this issue. (Obviously with exception of the bmi test which threw the "examiner field" error).

[skarya22]

@adamdaudrich I am a bit lost by the issue description -- to confirm you are saying that you tested tools/score_instrument.php and everything seemed okay in your tests except that the bmi instrument had the examiner error, which would ideally be solved by #9667, correct?

[adamdaudrich]

Yeah, I think we solved it with your _LINST fix.
I just want to test on my end because I had that weird ControlPanel error.

[adamdaudrich]

i've tested this with @skarya22 fix and it works.