-
Notifications
You must be signed in to change notification settings - Fork 188
[electrophysiology_browser] EventPanel 2.0 | HED Endorsement | Channels Support (EEG-BIDS) | Miscellaneous Features #10062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[electrophysiology_browser] EventPanel 2.0 | HED Endorsement | Channels Support (EEG-BIDS) | Miscellaneous Features #10062
Conversation
|
@jeffersoncasimir how about adding to the PR description something like : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note also: I edited the PR description for a bit more clarity esp for the release notes.
- HED link is down https://www.hed-resources.org/en/latest/index.html
maybe just link to HEDtags.org?
@jeffersoncasimir want to let me know for Monday if you need more info to reproduce these?
where I tested it on https://jcasimir-test-27.loris.ca/electrophysiology_browser/sessions/2161?outputType=raw:
- Dataset Tag manager button not visible - not testable.
- Tagged by / Endorsed by / Caveat By -> these lists are empty, feature is not usable. Is a patch / something else missing?
- Adding a second HED Artifact tag doesn't work: Message:
fill all the other tags first-- also if it's a warning /error it shouldn't be green.
Did more testing on : https://jcasimir-test-27.loris.ca/electrophysiology_browser/sessions/167?outputType=raw
- Adding any HED Artifact tag doesn't work
- Endorsement problem w keystrokes: If I use the key strokes (^ C or M) after clicking in the 3rd HED tag, it changes the 1st HED tag visible. Please disable and remove the hover text regarding keystrokes if it can't be fixed for this release
- can't undo my own Caveat.
- tried to remove 2 tags added by Data authors. It showed me the X next to each orange tag (suggesting I could) so I clicked. then clicked Submit. got an error message but no details. The orange tags disappear and the submit button greyed out, but when i navigate elsewhere I am asked to confirm that i will lose changes. If i refresh the orange tags are back (delete failed)
- from the HEd endorsement panel -- the edit pencil likewise suggests I can edit tags but I don't have that permission as
admin. either the messaging or the behaviour needs clarification. - unclear how to add a tag only to specific channels, without changing the channel scope of all tags. When I go to add a tag for only a few channels it changes the channels on all the existing tags added by Data Authors which are otherwise uneditable (or so it seems)
|
@christinerogers please retest and amend the list to remove items that were due to the timing in which you were testing (like a crucial button not being visible). You apparently caught my testing VM in a window where I was rebuilding to test another PR. Make sure to use the OTT recordings and not the random other one. Please note, an instance-level HED tag must be manually added (or present in the recording, which is not the case here) in order to appear on the list of HED endorsements. To test the (non-DTM) HED endorsement feature, you need to manually add a HED tag first. Also, some of these points are not realistically fixable for the release or are known by the EEGNet team and have a corresponding open issue. If any changes are requested, please formulate them as such. |
|
Followup PR can include:
|
|
2264590 to
32a3aa5
Compare
...ectrophysiology_browser/jsx/react-series-data-viewer/src/series/components/DatasetTagger.tsx
Outdated
Show resolved
Hide resolved
| 'Invalid output type' | ||
| )); | ||
| } | ||
| header("Cache-Control: no-store"); // Fixes tab re-open bug (json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "tab re-open bug (json)"?
I'm not sure if this works since session_cache_limiter has already been called, but the correct way to add headers is to add the header to the ResponseInterface returned using PSR7
…ls Support (EEG-BIDS) | Miscellaneous Features (aces#10062) This adds the latest EEG features from EEGNet. Notably, this includes a major overhaul to the Event Panel and adds the ability to "Endorse" HED tags - as well as caveat and/or comment. Filter/search also added. Additional features to support event channels: i.e. Events can be created/tagged for subsets of channels. - Toggle selection from montage view - Toggle selection from signals - time segment highlighting is now channel-based (all unless defined) Downloadable dynamic events.json file (Dataset Tag Manager) updates itself after new tags are added/used.



This PR adds the latest EEG features from EEGNet.
Notably, this includes a major overhaul to the Event Panel and adds the ability to "Endorse" HED tags - as well as caveat and/or comment. Filter/search also added.
Additional features to support event channels: i.e. Events can be created/tagged for subsets of channels.
Downloadable dynamic events.json file (Dataset Tag Manager) updates itself after new tags are added/used.
Screenshots:





