Changed TestBattery to accept CenterID as part of battery #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think the part of assign missing instruments that defines a $visit_ages array with median ages for the visit and the part that uses that fake median age to derive the battery needs to be reworked into a way that's more project independent before merging this into the main trunk (I think those actually come from my IBIS code, not Christine's..) As things stand, with this merge I'm not sure that assign_missing_instruments would work with anything other than IBIS. |
Contributor
|
Needs the table schema to be updated to add the CenterID as a field. Remove the add_timepoint instrument script from the commit. |
Collaborator
|
I removed the script from the commit, and updated the table schema. Can be reviewed/merged next meeting now, I think.. |
Contributor
|
Added CenterID to change the battery. IBIS is using this. NeuroDevnet ASD is using this and all looks good. |
samirdas
added a commit
that referenced
this pull request
Apr 26, 2012
Changed TestBattery to accept CenterID as part of battery
Jkat
referenced
this pull request
in Jkat/Loris
Oct 21, 2014
automatic set up of mri-pipeline infrastructure
driusan
added
Category: Feature
rathisekaran
pushed a commit
to rathisekaran/Loris
that referenced
this pull request
Jan 7, 2015
updating script to use existing function from candidate class
davidblader
added a commit
to davidblader/Loris
that referenced
this pull request
Feb 8, 2017
filtering for cohorts
ZainVirani
pushed a commit
to ZainVirani/Loris
that referenced
this pull request
Jul 12, 2017
parser update
HenriRabalais
referenced
this pull request
in HenriRabalais/Loris
Feb 17, 2020
[Consent] Add COPN consent (Patient + Surrogate) Version 1
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Oct 19, 2020
updated Modal functionality
driusan
pushed a commit
that referenced
this pull request
Feb 24, 2025
The candidate list module was not loading on some VMs with the following error: `[Fri Feb 21 11:54:24.183216 2025] [php:error] [pid 41249] [client ::1:38026] PHP Fatal error: Uncaught PDOException: SQLSTATE[42000]: Syntax error or access violation: 1055 Expression #6 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'cbeaudoin_dev.c.Entity_type' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by in /var/www/loris/src/Database/Query.php:46\nStack trace:\n#0 /var/www/loris/src/Database/Query.php(46): PDOStatement->execute()\n#1 /var/www/loris/src/Data/Provisioners/DBRowProvisioner.php(90): LORIS\\Database\\Query->getIterator()\n#2 [internal function]: LORIS\\Data\\Provisioners\\DBRowProvisioner->getAllInstances()\n#3 [internal function]: FilterIterator->rewind()\n#4 /var/www/loris/src/Http/DataIteratorBinaryStream.php(239): FilterIterator->rewind()\n#5 [internal function]: LORIS\\Http\\DataIteratorBinaryStream->rowGenerator()\n#6 /var/www/loris/src/Http/DataIteratorBinaryStream.php(189): Generator->valid()\n#7 /var/www/loris/src/Http/GzipStream.php(160): LORIS\\Http\\DataIteratorBinaryStream->read()\n#8 /var/www/loris/htdocs/index.php(102): LORIS\\Http\\GzipStream->read()\n#9 {main}\n thrown in /var/www/loris/src/Database/Query.php on line 46, referer: http://localhost:8080/candidate_list/` There were fields missing from the GROUP BY statement. This adds all missing fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks :
LookupBattery() in Battery class has been updated to permit battery population filtering by CenterID, for site-specific instruments.
Calls to this function were also modified in assign_missing_instruments.php and NDB_Form_next_stage.class.inc, to pass in the CenterID
Additionally, some code was refactored and moved from inline to the function Populate Visit - Dave's previous change for IBIS.
Note: this change was executed by Christine (but using mia's megamind setup)