[dev] Remove shellcheck from make checkstatic #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR aces#6053 added the "shellcheck" tool to our static analysis suite to lint shell scripts. However, the PR added it to `make checkstatic` prematurely. 1. The wrapper shell script does not run on MacOS because it depends on newer bash options. 2. The script requires a third party tool which is not managed by any of our dependency managers (npm, composer, etc) to be installed. The result is that developers can no longer run `make checkstatic` to check their code without running through hoops. This removes it from the checkstatic target, since it currently prevents developers from working on LORIS.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
PR aces#6053 added the "shellcheck" tool to our static analysis suite to lint shell scripts. However, the PR added it to `make checkstatic` prematurely. 1. The wrapper shell script does not run on MacOS because it depends on newer bash options. 2. The script requires a third party tool which is not managed by any of our dependency managers (npm, composer, etc) to be installed. The result is that developers can no longer run `make checkstatic` to check their code without running through hoops. This removes it from the checkstatic target, since it currently prevents developers from working on LORIS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6053 added the "shellcheck" tool to our static analysis suite
to lint shell scripts. However, the PR added it to
make checkstaticprematurely.
on newer bash options.
any of our dependency managers (npm, composer, etc) to be installed.
The result is that developers can no longer run
make checkstaticto check their code without running through hoops. This removes
it from the checkstatic target, since it currently prevents developers
from working on LORIS.