Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LINST] Fixed default date field null error #7559

Merged
merged 1 commit into from Aug 31, 2021

Conversation

ridz1208
Copy link
Collaborator

@ridz1208 ridz1208 commented Aug 31, 2021

Brief summary of changes

This PR fixes a PHP typing issue caused by the default values of a dateElement generated from the instrument builder

Error:

[php7:error] [pid 14345] [client 10.121.40.204:59323] PHP Fatal error:  Uncaught TypeError: Argument 3 passed to NDB_BVL_Instrument::addDateElement() must be of the type array, null given, called in /var/www/loris/php/libraries/NDB_BVL_Instrument_LINST.class.inc on line 620 and defined in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc:1900\nStack trace:\n#0 /var/www/loris/php/libraries/NDB_BVL_Instrument_LINST.class.inc(620): NDB_BVL_Instrument->addDateElement('collection_date', '3. 

Instrument section

...
date{@}collection_date_date{@}3. Date of tissue collection:{@}1900{@}2100{@}
...

More details:
When creating a date element in the instrument builder without specifying start and end values, the module defaults the values
to 1900 and 2100 which in turn cause an error when rendering the instrument. This should fix that error without changing any functionality

@ridz1208 ridz1208 added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Aug 31, 2021
@ridz1208 ridz1208 modified the milestone: 23.0.6 Aug 31, 2021
@driusan driusan merged commit db58afb into aces:23.0-release Aug 31, 2021
@ridz1208 ridz1208 added this to the 23.0.7 milestone Sep 15, 2021
@ridz1208 ridz1208 modified the milestones: 23.0.7, 23.0.8 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants