Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes all the things :) #5

Merged
merged 24 commits into from Mar 13, 2013

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Dec 14, 2012

Hi!

I made a whole bunch of changes to the nbt library. It completely breaks the API as you know it, but it should be more performant (Text instead of String, Array Int32 instead of []) and usable (all Maybe String fields are gone, making it a bit easier to parse NBT-encoded structures).

I hope you find my changes useful. If you plan to merge, make sure to revert the changes I made to README.md.

Kind regards,

Stijn

lashtear and others added some commits Aug 23, 2012

Merge branch 'Branch_0.3'
Conflicts:
	src/Data/NBT.hs
Eradicated EndTag.
EndTag is only a terminating tag for compound tags, and isn't an actual part of the logical NBT structure.
Use `fail` instead of `error` in the Get monad.
The good news is that Get has a simple way to communicate failure, so `error` isn't needed. The bad news is that it's done through `fail`.
Merge commit '5188cd501f4696c58e1c786f48a49957faec6277'
Conflicts:
	nbt.cabal
	src/Data/NBT.hs
Disabled Travis-CI's e-mail notifications.
travis
wat r u doin
travis
stahp!
Owner

acfoltzer commented Dec 14, 2012

Hi Stijn,

Thanks a ton for this! These are a bunch of changes I've been meaning to
make.

I'm really busy presently, but will try to get this merged ASAP.

Adam

On Fri, Dec 14, 2012 at 7:18 AM, Stijn van Drongelen <
notifications@github.com> wrote:

Hi!

I made a whole bunch of changes to the nbt library. It completely breaks
the API as you know it, but it should be more performant (Text instead of
String, Array Int32 instead of []) and usable (all Maybe String fields
are gone, making it a bit easier to parse NBT-encoded structures).

I hope you find my changes useful. If you plan to merge, make sure to
revert the changes I made to README.md.

Kind regards,

Stijn

You can merge this Pull Request by running:

git pull https://github.com/Tinctorius/nbt master

Or view, comment on, or merge it at:

#5
Commit Summary

  • add basic support for IntArrays
  • update test suite to use cabal and replace error with fail
  • update cabal file description and tested-with
  • added support for new Int_Array tag
  • changed ByteArray representation to an array of bytes
  • Added support for TAG_Int_Array.
  • corrected pointer to repository
  • Merge branch 'Branch_0.3'
  • Remove explicit payload size from data structure.
  • ListTag now carries an array.
  • Eradicated EndTag.
  • Use fail instead of error in the Get monad.
  • Merge commit '5188cd501f4696c58e1c786f48a49957faec6277'
  • Removed length field of TagString.
  • Merge branch 'Branch_d2043bcdbf3f1f161daba82185bbf1bcafb116d6'
  • NBT utilities: typeOf and nameOf
  • Toggle .travis.yml
  • Toggle .travis.yml
  • drop version constraints on test-framework* packages
  • sigh... Travis-ci has case-sensitive URLs
  • Disabled Travis-CI's e-mail notifications.
  • Removed EndType.
  • Moved names of tags to compound tags.
  • Turned String field of StringTag into Text.

File Changes

  • M .travis.yml (2)
  • M README.md (4)
  • M nbt.cabal (66)
  • M src/Data/NBT.hs (284)
  • A test/RoundTrip.hs (87)
  • D test/Tests.hs (81)
  • D test/nbt-tests.cabal (23)

Patch Links

Owner

acfoltzer commented Mar 13, 2013

Hi Stijn,

I'm merging this now; thanks for the reminder. Would it be okay to mention
you in the cabal Authors section?

On Wed, Mar 13, 2013 at 11:04 AM, Stijn van Drongelen <
notifications@github.com> wrote:

Bump? ^_^


Reply to this email directly or view it on GitHubhttps://github.com/acfoltzer/nbt/pull/5#issuecomment-14858389
.

@ghost

ghost commented Mar 13, 2013

Certainly :) You can mention me as Stijn van Drongelen <rhymoid@gmail.com> (if you need that e-mail address).

@acfoltzer acfoltzer merged commit 22d4f2c into acfoltzer:master Mar 13, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment