feat(exact): report determinant scale overflow precisely#141
Conversation
- Add a typed LaError::DeterminantScaleOverflow path for exact determinant scale exponent failures - Convert det_exact_f64 directly from the shared Bareiss integer/exponent pair while preserving Overflow for finite-f64 conversion failures - Reuse vector finiteness scanning across raw and proof-bearing constructors - Harden docs version sync checks for reordered inline-table dependency snippets and pruned Markdown traversal Closes #139
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRefactors exact determinant→f64 conversion to use a direct bigint+exponent helper and adds DeterminantScaleOverflow; centralizes vector finiteness scanning; removes redundant LU/LDLT tolerance tests; and improves docs-version-sync script, tests, and CHANGELOG entries. ChangesExact Determinant Scaling and Error Handling
Vector Finiteness Centralization
Documentation Sync Tooling and Changelog
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 99.47% 99.61% +0.14%
==========================================
Files 5 5
Lines 2838 2846 +8
==========================================
+ Hits 2823 2835 +12
+ Misses 15 11 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Extract determinant scale exponent calculation into a private helper - Assert typed DeterminantScaleOverflow errors for dimension conversion and exponent product overflow
Closes #139
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests