Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed DropDown. See commit comment for description of problem. #12

merged 1 commit into from Mar 7, 2012


None yet
2 participants

alanshaw commented Mar 6, 2012

Made use of GUIWidget.render method for JIT rendering - which greatly simplified the setOptions method and means we don't have to explicitly call setOptions from the class constructor.

@alanshaw alanshaw Fix and test for form DropDown. Previously, the DropDown class was no…
…t selecting the correct <option> element when passed a "value" in it's class options object. When called by the superclass constructor, _setRawValue couldn't use options.value to set the selected <option> because setOptions hadn't been called yet to create the elements...and when it was called by the DropDown class, setOptions could not preserve the currently selected index because _setRawValue hadn't been able to set the selected <option>.

@achingbrain achingbrain added a commit that referenced this pull request Mar 7, 2012

@achingbrain achingbrain Merge pull request #12 from alanshaw/master
Fixed DropDown. See commit comment for description of problem.

@achingbrain achingbrain merged commit 50837fe into achingbrain:master Mar 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment