New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(very) basic iTerm support #52

Merged
1 commit merged into from Feb 1, 2011

Conversation

Projects
None yet
2 participants
@recurser
Contributor

recurser commented Jan 12, 2011

Hey guys, this seems to be the bare minimum to get iTerm working - iterm_capture.rb is a direct copy of mac_capture, so there's probably a cleaner way to do it other than copying the whole file.

I'm not very happy with the lib/terminitor.rb or lib/terminitor/runner.rb stuff i did - there needs to be a more extensible way to support multiple clients on a platform, but I just kind of threw this together for my own use.

I've had a go at adding an iterm_core_test.rb but i can't figure out how to get the window option tests to pass - I don't really use the options stuff and unfortunately I don't have time at the moment to write proper tests :( I haven't committed any of the test stuff since it's a bit of a mess.

Anyway feel free to ignore this or use any of iterm_core.rb that you want - I haven't changed much from mac_core.rb and i'm not even sure what i've changed is correct, but it seems to work for the basic terminitor commands i've been using.

thanks for your hard work - much appreciated!

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Jan 13, 2011

Owner

is this for iTerm or iTerm2? is there a difference really? I don't use iTerm so i'm not too familiar. I want to download it and give it a try and work on it a bit myself with whatever you have done here.

Owner

achiu commented Jan 13, 2011

is this for iTerm or iTerm2? is there a difference really? I don't use iTerm so i'm not too familiar. I want to download it and give it a try and work on it a bit myself with whatever you have done here.

@recurser

This comment has been minimized.

Show comment
Hide comment
@recurser

recurser Jan 13, 2011

Contributor

I wrote it for iTerm - I've tried it briefly on iTerm2 and it seems to work the same - I'm not sure what the difference is as I've never really used iTerm2 except to test this. The window options stuff probably doesn't work at all on either :) I just got the basic tab/window opening and commands running. I wouldn't recommend pulling this wholesale, but it might be a good base for getting iTerm working.

Contributor

recurser commented Jan 13, 2011

I wrote it for iTerm - I've tried it briefly on iTerm2 and it seems to work the same - I'm not sure what the difference is as I've never really used iTerm2 except to test this. The window options stuff probably doesn't work at all on either :) I just got the basic tab/window opening and commands running. I wouldn't recommend pulling this wholesale, but it might be a good base for getting iTerm working.

@recurser

This comment has been minimized.

Show comment
Hide comment
@recurser

recurser Jan 13, 2011

Contributor

I guess basically all I've done is get execute_command(), open_tab(), open_window(), return_last_tab() & active_window() working (i think). It might take quite a bit of work to get everything else working, but it's usable for basic use-cases.

Contributor

recurser commented Jan 13, 2011

I guess basically all I've done is get execute_command(), open_tab(), open_window(), return_last_tab() & active_window() working (i think). It might take quite a bit of work to get everything else working, but it's usable for basic use-cases.

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Jan 13, 2011

Owner

ok i'll check it out and play with iTerm a bit. thanks for the commit/contribution regardless =)

Owner

achiu commented Jan 13, 2011

ok i'll check it out and play with iTerm a bit. thanks for the commit/contribution regardless =)

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Feb 1, 2011

Owner

i've pulled in your changes and added some basic tests for the features for now. thanks for the commits!

Owner

achiu commented Feb 1, 2011

i've pulled in your changes and added some basic tests for the features for now. thanks for the commits!

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment