Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, this seems to be the bare minimum to get iTerm working - iterm_capture.rb is a direct copy of mac_capture, so there's probably a cleaner way to do it other than copying the whole file.
I'm not very happy with the lib/terminitor.rb or lib/terminitor/runner.rb stuff i did - there needs to be a more extensible way to support multiple clients on a platform, but I just kind of threw this together for my own use.
I've had a go at adding an iterm_core_test.rb but i can't figure out how to get the window option tests to pass - I don't really use the options stuff and unfortunately I don't have time at the moment to write proper tests :( I haven't committed any of the test stuff since it's a bit of a mess.
Anyway feel free to ignore this or use any of iterm_core.rb that you want - I haven't changed much from mac_core.rb and i'm not even sure what i've changed is correct, but it seems to work for the basic terminitor commands i've been using.
thanks for your hard work - much appreciated!