New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minute and second stepping may make more sense with min=0 and max=60 #263

Closed
taivo opened this Issue Dec 4, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@taivo
Copy link

taivo commented Dec 4, 2014

This is in regard to the datetime component. Currently, the minute and second stepping seems to be tied to minDate, and that leads to a somewhat strange situation. Suppose stepMinute is set to 15, and minDate happen to be 2-Dec-2014 4:02 PM, the minute steps end up being 2, 17, 32, 47.

The work around is setting the minute and second components of minDate to be divisible by stepMinute. This issue is not readily observable when minDate is not specified because the default minDate value has zero for its minute and second components.

I wonder if it makes more sense to just lock the variables minM and minS in datetimebase.js (around line 101) to zero?

@dioslaska

This comment has been minimized.

Copy link
Contributor

dioslaska commented Dec 16, 2014

We need to support both behaviors (see #204).

Added a new steps setting, example usage:

steps: {
    hour: 1,
    minute: 15,
    second: 5,
    zeroBased: true
}

zeroBased is false by default to avoid backward compatibility issues.

stepHour, stepMinute, stepSecond still works if steps not specified, but is deprecated.

@dioslaska

This comment has been minimized.

Copy link
Contributor

dioslaska commented Dec 17, 2014

Added in 2.14.3

@dioslaska dioslaska closed this Dec 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment