New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobiscroll.widget.jqm.js cannot be used in combination jquery.mobile + requirejs #279

Closed
DzenisevichK opened this Issue Feb 2, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@DzenisevichK
Copy link

DzenisevichK commented Feb 2, 2015

mobiscroll.widget.jqm.js file contains:

var ver = $.mobile && $.mobile.version && $.mobile.version.match(/1\.4/);

which depends on $.mobile which in case of (1.4.5 version) and requirejs will be undefined in release version (combined build) even when shim is specified:

require.config({
    shim: {
        "external/mobiscroll": {
            deps: ["external/jquery", "external/jquery.mobile"]
        }
    }
});
@dioslaska

This comment has been minimized.

Copy link
Contributor

dioslaska commented Feb 18, 2015

Hello, here is an example, using RequireJS and jQuery Mobile. It works for me:

https://dl.dropboxusercontent.com/u/34664815/mobiscroll.require.jqm.zip

@DzenisevichK

This comment has been minimized.

Copy link

DzenisevichK commented Mar 5, 2015

@dioslaska

Your example a bit not exactly which necessary.

Check this one version:
https://www.dropbox.com/s/fsnp7t9kyvtl0pt/mobiscroll.require.jqm.zip?dl=0

It built with r.js to reproduce the problem:
node_modules\.bin\r.js.cmd -o build.js
(command line for Windows)

I fixed jquery.mobile asynchronous loading + added mobiscroll.mine.js (not minified) and you can debug problem with it...

dioslaska added a commit that referenced this issue Sep 2, 2015

@dioslaska dioslaska added this to the 2.17.0 milestone Sep 2, 2015

@dioslaska

This comment has been minimized.

Copy link
Contributor

dioslaska commented Sep 2, 2015

Fixed, will be released in 2.17.0

@dioslaska dioslaska closed this Sep 2, 2015

@DzenisevichK

This comment has been minimized.

Copy link

DzenisevichK commented Sep 3, 2015

Ok, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment