New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tap"-event incompatible with fastclick.js on iPhone/iPad #83

Closed
lebbe opened this Issue Mar 5, 2013 · 0 comments

Comments

Projects
None yet
2 participants
@lebbe
Copy link
Contributor

lebbe commented Mar 5, 2013

The tap-event defined for the set and cancel buttons are incompatible with fastclick.js, and probably similar js plugins/extensions. Fastclick removes the 300 ms delay on iPhone/iPad, and mobiscroll (implicitly) relies on this delay for handling "tap" instead of "click". What happens is that both a "tap" and a "click" is sent.

This is easily reproducible: Import both mobiscroll 2.4.4 and fastclick in same document, make the body clickable (for instance displaying an alert), and bring up a mobiscroll dialog. When Cancel or Set is "clicked" on iPhone/iPad, the body (element below) also recieves a click.

I don't know whether this is a "bug", possible new "feature" or what. But I would think combining both mobiscroll and fastclick (or something similar) on handheld web-applications are fairly common and should be addressed?

Workaround:

I found disabling the "tap"-event in mobiscroll fixed my issue. Just make the Set and Cancel-buttons listen to click again. Since fastclick solves the same issue as "tap" in mobiscroll, this seems like a fine solution. Perhaps make it an option whether to use "tap" on Set and Cancel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment