New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure onCancel always fires. #58

Merged
merged 1 commit into from Jan 25, 2013

Conversation

Projects
None yet
2 participants
@zewt
Copy link
Contributor

zewt commented Jan 24, 2013

mobiscroll.jqm.js calls hide() when the user clicks the underlay, which doesn't
call onCancel. Fix this so clicking the underlay has the same behavior as clicking
cancel. Otherwise, there's no way to reliably do things on cancellation, since
you can't tell if it's a cancel or save from onClose (the only event that was being
called before).

Make sure onCancel always fires.
mobiscroll.jqm.js calls hide() when the user clicks the underlay, which doesn't
call onCancel.  Fix this so clicking the underlay has the same behavior as clicking
cancel.  Otherwise, there's no way to reliably do things on cancellation, since
you can't tell if it's a cancel or save from onClose (the only event that was being
called before).

dioslaska added a commit that referenced this pull request Jan 25, 2013

@dioslaska dioslaska merged commit dbdf14f into acidb:master Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment