Fix PuppetDB 4 support #42
Conversation
|
Thank you for merging |
|
@raphink yeah sorry I am currenty focusing most of my time on https://forge.puppet.com/puppetlabs/catalog_preview with the language team to get its overview-json output to be sort of close this tools output in terms of content, most of the changes are in HEAD https://github.com/puppetlabs/puppetlabs-catalog_preview and I built a little json -> html https://github.com/puppetlabs/prosvc-preview_report (your js would wayy better but as its a different format of the json I have decided to build a little POC) . I think I may move this catalog_diff fork into the opensource realm only as I won't have time to keep it up now that we have catalog_preview officially open sourced , but honestly after playing with preview, it's a better tool as ties into the "issues" api stuff that was added to puppet at least for catching common upgrade issues. |
|
OK so you would recommend using the preview tool now? If so, I might want to try it, dockerize it for our rancher infra and contribute to a web interface if needed. |
|
@raphink the preview tool is being actively developed by the puppet language team and so will continue to get better and better compared to this tool (and it has hooks into the puppet compiler itself) , right now there is relative parity ( though as mentioned the issues stuff in preview is very slick and already better for upgrades). There are a few things that you may notice in the linked json-> html ruby example, like the json in the current tool has the code snippets embedded where as with preview I am pulling the code off disk in the html convertor. If you give it a shot and get snagged on anything , please @ mention me on the tickets on jira https://tickets.puppetlabs.com/browse/PRE There is a general consensus that your web interface is right where we want to be but my lack of JS skills prevented me consuming what you had already written in my quick Proof of concept development time scale. If you are willing to contribute a web interface for preview I will be glad to help you along the way with anything needed on the puppet/preview side as a facilitator :) |
|
Thanks for the info. I can't tell when I'll be able to work on that, given that so far the catalog diff works for us, but I'm definitely interested. |
No description provided.