New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven build #2

Closed
bengtmartensson opened this Issue Jun 29, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@bengtmartensson
Contributor

bengtmartensson commented Jun 29, 2017

Today, a Maven build is almost a requirement for integration in the Java/free software ecosystem.

I have a Mavenized "fork", but I would like some feedback before I start working on a pull request.

@aclemons

This comment has been minimized.

Show comment
Hide comment
@aclemons

aclemons Jun 29, 2017

Owner

It might be nice for people hacking on java-readline or projects with a dependency on it.

But speaking with my package maintainer cap on, we must not make maven mandatory for building. Luckily, this project currently has no extra java dependencies, so it would be simple enough to support a maven build and an ant or simple javac based build simultaneously.

Owner

aclemons commented Jun 29, 2017

It might be nice for people hacking on java-readline or projects with a dependency on it.

But speaking with my package maintainer cap on, we must not make maven mandatory for building. Luckily, this project currently has no extra java dependencies, so it would be simple enough to support a maven build and an ant or simple javac based build simultaneously.

@aclemons aclemons closed this in 1b9c74f Jul 2, 2017

@aclemons

This comment has been minimized.

Show comment
Hide comment
@aclemons

aclemons Jul 2, 2017

Owner

I cherry-picked the changes from your repo and updated a couple of things. I have elected to not move all the files to match the maven conventions for now. That might be something for 1.0.

Owner

aclemons commented Jul 2, 2017

I cherry-picked the changes from your repo and updated a couple of things. I have elected to not move all the files to match the maven conventions for now. That might be something for 1.0.

@bengtmartensson

This comment has been minimized.

Show comment
Hide comment
@bengtmartensson

bengtmartensson Jul 2, 2017

Contributor

Great. I do not think it is necessary to change the directory structure.

Contributor

bengtmartensson commented Jul 2, 2017

Great. I do not think it is necessary to change the directory structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment