Added support for Google Cloud DNS API (dns_gcloud) #1623
Conversation
|
please move it the last position. |
|
I can see this is not yet merged into dev branch but marked as closed |
dnsapi/dns_gcloud.sh
Outdated
|
|
||
| for i in $(seq 1 120); do | ||
| if gcloud dns record-sets changes list \ | ||
| --zone=lenart \ |
There was a problem hiding this comment.
Risking being a little more directive than @chessmango , I believe he means you should replace lenart with "$managedZone". ;-)
You might also indicate what sort of testing you've done to speed up acceptance.
There was a problem hiding this comment.
whops, fixed. Worked for me! :-D
| } | ||
|
|
||
| _dns_gcloud_remove_rrs() { | ||
| if ! xargs --no-run-if-empty gcloud dns record-sets transaction remove \ |
There was a problem hiding this comment.
There might be more than one value to be removed (a TXT can be multivalue), so we need the xargs.
|
@thejaswip The security/acme-client: add support for Google Domains API issue is for |
dnsapi/dns_gcloud.sh
Outdated
| | while read -r dnsName name; do | ||
| printf "%s\t%s\t%s\n" "${#dnsName}" "$dnsName" "$name" | ||
| done \ | ||
| | sort -n -r | head -n1 | cut -f2,3 | grep '^.*'); then |
There was a problem hiding this comment.
please use _head_n() function ?
|
please merge the latest code and check this guide first: |
|
@lenartj The changes above look reasonably small - any chance to re-submit? |
|
I've replied to your comments and rebased the code. About the guide, I think 6/2 is not practical for gcloud; about 6/5 I think I have grep, cut, head, xargs that are not shell builtins (and printf, depending on the shell). It is possible to rewrite the code not use xargs and printf, but I do not have the time for it, sorry. |
|
please merge the latest code. |
|
Done :-) |
See also #180