{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1506403,"defaultBranch":"main","name":"OpenShadingLanguage","ownerLogin":"aconty","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2011-03-21T12:01:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/433520?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1682328891.0","currentOid":""},"activityList":{"items":[{"before":"9420e8bbb6a05716f0c1f157875d4db50e951e5f","after":"7fd9c3f88c0a5cc12130cf64ec5ac82fc54df1ee","ref":"refs/heads/main","pushedAt":"2024-01-18T17:41:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aconty","name":"Alejandro Conty","path":"/aconty","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/433520?s=80&v=4"},"commit":{"message":"admin: git blame ignore for recent formatting change\n\nSigned-off-by: Larry Gritz <lg@larrygritz.com>","shortMessageHtmlLink":"admin: git blame ignore for recent formatting change"}},{"before":"57eeb7a46c194d0e10884ef0b9420604e8b05c3d","after":"9420e8bbb6a05716f0c1f157875d4db50e951e5f","ref":"refs/heads/main","pushedAt":"2023-06-19T16:24:11.302Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aconty","name":"Alejandro Conty","path":"/aconty","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/433520?s=80&v=4"},"commit":{"message":"Zero derivs for interactive params when needed\n\nSometimes an interactive param is used in a way that gets\nflagged as needing derivs. But we were neither allocating space\nfor that nor zeroing them. This resulted on memory corruption.\n\nSigned-off-by: Alejandro Conty <aconty@imageworks.com>","shortMessageHtmlLink":"Zero derivs for interactive params when needed"}},{"before":"0209d6bf03f0d9487f5a04aa7e8d69f3c6feabd6","after":"57eeb7a46c194d0e10884ef0b9420604e8b05c3d","ref":"refs/heads/main","pushedAt":"2023-06-09T16:36:42.211Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aconty","name":"Alejandro Conty","path":"/aconty","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/433520?s=80&v=4"},"commit":{"message":"Don't try to ReParameter symbols not in the group\n\nSometimes, after optimization, symbols tagged as interactive\nget removed because they are unused. But ReParameter is failing\nwith errors because it goes looking for the removed symbol to\nmaster, which is, of course, not interactive. This patch avoids\nthat so the symbol is not found and we just return false.\n\nSigned-off-by: Alejandro Conty <aconty@imageworks.com>","shortMessageHtmlLink":"Don't try to ReParameter symbols not in the group"}},{"before":"37f4bbc1a29fb6884f14e80118c1c6c5ff02c876","after":"0209d6bf03f0d9487f5a04aa7e8d69f3c6feabd6","ref":"refs/heads/main","pushedAt":"2023-06-09T10:53:37.062Z","pushType":"push","commitsCount":20,"pusher":{"login":"aconty","name":"Alejandro Conty","path":"/aconty","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/433520?s=80&v=4"},"commit":{"message":"Don't try to ReParameter symbols not in the group\n\nSometimes, after optimization, symbols tagged as interactive\nget removed because they are unused. But ReParameter is failing\nwith errors because it goes looking for the removed symbol to\nmaster, which is, of course, not interactive. This patch avoids\nthat so the symbol is not found and we just return false.\n\nSigned-off-by: Alejandro Conty <aconty@imageworks.com>","shortMessageHtmlLink":"Don't try to ReParameter symbols not in the group"}},{"before":null,"after":"612da8f232053aaf97040da3492c00c7f7847623","ref":"refs/heads/bind_fix","pushedAt":"2023-04-24T09:34:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aconty","name":"Alejandro Conty","path":"/aconty","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/433520?s=80&v=4"},"commit":{"message":"Fix userdata binding corner case\n\nThis includes two fixes:\n\n 1) When registering symbols that need user data, sort the entries in\n the set so the layer number is ignored. A needed udata iteam shouldn't\n depend on the layer and separating them makes find_userdata_index()\n sometimes find an index with different derivs status.\n\n 2) osl_bind_interpolated_param() is memcpy'ing derivs that might not\n be there, yielding corrupted derivs and possibly a crash.\n\nSigned-off-by: Alejandro Conty <aconty@imageworks.com>","shortMessageHtmlLink":"Fix userdata binding corner case"}},{"before":"55029e388fe677a2183fc576e73e714df06e6156","after":"37f4bbc1a29fb6884f14e80118c1c6c5ff02c876","ref":"refs/heads/main","pushedAt":"2023-04-24T09:13:47.000Z","pushType":"push","commitsCount":81,"pusher":{"login":"aconty","name":"Alejandro Conty","path":"/aconty","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/433520?s=80&v=4"},"commit":{"message":"Make recent run-layer optimizations optional, and fix init ops-related false positive (#1672)\n\nMy initial implementation of the run layer check optimizations didn’t account for the fact that init ops for symbols have their llvm code generated before we build basic blocks from the OSL IR.\r\n\r\nThis caused the code to be wrong in two ways: 1) the set of known run layer calls was being reset between instances too late in the pipeline, so a useparam inside an init op would actually be checking the previously compiled layer’s set, and 2) even when reset earlier, it assumed valid basic block ids existed for the init ops when they did not.\r\n\r\nSo, if a layer had a useparam inside one of its init ops that generally matched the same code location as a useparam in the previously compiled layer, the run layer check could be incorrectly omitted.\r\n\r\nI’ve updated the code so that the default optimization behavior is reverted to the way it was before #1665, and added a new option opt_useparam that can be turned on to enable a fixed, restricted version of the optimization that only applies to code in the main section.\r\n\r\nI'm working on a test that properly triggers the issue.\r\n\r\nSigned-off-by: Chris Hellmuth <chellmuth@gmail.com>","shortMessageHtmlLink":"Make recent run-layer optimizations optional, and fix init ops-relate…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD40fkqgA","startCursor":null,"endCursor":null}},"title":"Activity · aconty/OpenShadingLanguage"}