Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

@keyallis
Copy link
Contributor

@keyallis keyallis commented Jul 28, 2023

#1726

Abstracted out validation support for nested acorn validation on app server endpoints.

Verified that acorn upgrade is still blocked from being called on nested acorns.
Verified that acorn upgrade --confirm-upgrade is allowed to call nested acorns.
Verified that the above call triggers an update to the nested acorn.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@keyallis keyallis marked this pull request as ready for review July 28, 2023 18:51
@keyallis keyallis changed the title Nested acorn validation support on confirm-upgrade (#1726) Nested acorn validation support for acorn update --confirm-upgrade (#1726) Jul 28, 2023
Copy link
Contributor

@thedadams thedadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits, otherwise looks good.

@ibuildthecloud
Copy link
Member

acorn update --pull should work for nested acorns. Is that the case? All other updates should be blocked.

@g-linville
Copy link
Contributor

acorn update --pull should work for nested acorns. Is that the case? All other updates should be blocked.

@ibuildthecloud I don't remember if --pull works but imo --confirm-upgrade needs to be allowed as well. Otherwise this configuration becomes useless:

acorns: "my-acorn": {
  image: "myimage"
  autoUpgrade: true
  notifyUpgrade: true
}

Signed-off-by: Oscar Ward <oscar@acorn.io>
@keyallis keyallis merged commit daf8b68 into acorn-io:main Jul 31, 2023
@keyallis keyallis deleted the issue-1726 branch July 31, 2023 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants