Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log platform correctly #19

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@kamaradclimber
Copy link
Collaborator

kamaradclimber commented Nov 30, 2018

log is a chef resource which is updated at each run.
For users willing to decrease the amount of resources considered at each
run (to monitor the updates done by chef), this is necessary to use
Chef::Log mechanism instead.

In practice it will move the log line from convergence phase (when
resource are converged/executed) to compilation phase (when recipe code
is read)

Change-Id: Ia6599b30b2bcb2ce585f1f15653c2f389fc94047
Signed-off-by: Grégoire Seux g.seux@criteo.com

Log platform correctly
`log` is a chef resource which is updated at each run.
For users willing to decrease the amount of resources considered at each
run (to monitor the updates done by chef), this is necessary to use
Chef::Log mechanism instead.

In practice it will move the log line from convergence phase (when
resource are converged/executed) to compilation phase (when recipe code
is read)

Change-Id: Ia6599b30b2bcb2ce585f1f15653c2f389fc94047
Signed-off-by: Grégoire Seux <g.seux@criteo.com>
@kamaradclimber

This comment has been minimized.

Copy link
Collaborator Author

kamaradclimber commented Apr 8, 2019

@acornies would you have feedback on this change?

@kamaradclimber kamaradclimber requested a review from acornies Apr 8, 2019

@acornies
Copy link
Owner

acornies left a comment

This looks ok to me.

@acornies acornies merged commit 87bb913 into acornies:dev Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.