New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ROS Service client #24

Closed
wants to merge 2 commits into
base: dev
from

Conversation

Projects
None yet
2 participants
@rgleichman
Collaborator

rgleichman commented Oct 29, 2014

This commit adds support for generating service messages and calling ROS services. This does not implement a ROS service provider. The most of the new code written after Services code review 1 are in pkgBuilder and depFinder.

Show outdated Hide outdated src/executable/PkgBuilder.hs Outdated
@acowley

This comment has been minimized.

Show comment
Hide comment
@acowley

acowley Nov 4, 2014

Owner

Any thoughts on dealing with the Travis build failures? Ideally, Travis could still run the tests, but I'd be fine with only a subset of tests running on Travis while the rest require a bit more setup.

Owner

acowley commented Nov 4, 2014

Any thoughts on dealing with the Travis build failures? Ideally, Travis could still run the tests, but I'd be fine with only a subset of tests running on Travis while the rest require a bit more setup.

@rgleichman

This comment has been minimized.

Show comment
Hide comment
@rgleichman

rgleichman Nov 5, 2014

Collaborator

Yes, I think Travis should only run a subset of the tests. This would mean it would run cabal test testexe instead of cabal test. Ideally, all of the tests (including service and topic tests) would be automated too.

Collaborator

rgleichman commented Nov 5, 2014

Yes, I think Travis should only run a subset of the tests. This would mean it would run cabal test testexe instead of cabal test. Ideally, all of the tests (including service and topic tests) would be automated too.

@acowley

This comment has been minimized.

Show comment
Hide comment
@acowley

acowley Dec 2, 2014

Owner

Merged!

Owner

acowley commented Dec 2, 2014

Merged!

@acowley acowley closed this Dec 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment