Acpica access #138
Merged
Acpica access #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetalog
force-pushed
the
acpica-access
branch
4 times, most recently
from
ca6a1ed
to
9a9e07d
Compare
| @@ -167,13 +167,21 @@ AcpiHwGetAccessBitWidth ( | |||
|
|
|||
| if (!Reg->AccessWidth) | |||
| { | |||
| if (Reg->SpaceId == ACPI_ADR_SPACE_SYSTEM_IO) | |||
| if (Reg->BitWidth && !(Reg->BitWidth & 0x07) && | |||
| ACPI_IS_POWER_OF_TWO (Reg->BitWidth >> 3)) | |||
| { | |||
There was a problem hiding this comment.
It looks we could further limit this to:
if (!Reg->BitOffset && Reg->BitWidth &&
ACPI_IS_POWER_OF_TWO (Reg->BitWidth) && ACPI_IS_ALIGNED(Reg->BitWidth, 8) &&
ACPI_IS_ALIGNED(Reg->Address, Reg->BitWidth))
added 3 commits
May 4, 2016 10:22
This patch fixes 2 issues in AccessWidth/BitOffset support and adds comments to justify the BitOffset/BitWidth style macro usages. Lv Zheng. Signed-off-by: Lv Zheng <lv.zheng@intel.com>
This patch introduces ACPI_IS_ALIGNED() macro. Lv Zheng. Signed-off-by: Lv Zheng <lv.zheng@intel.com>
The old register descriptors are translated in AcpiTbInitGenericAddress() with AccessWidth being filled with 0. This breaks code in AcpiHwGetAccessBitWidth() when the registers are 16-bit IO ports and their BitWidth fields are filled with 16. The rapid fix is meant to make code written for AcpiHwGetAccessBitWidth() regression safer before the issue is correctly fixed from AcpiTbInitGenericAddress(). Reported by John Baldwin <jhb@freebsd.org>, Fixed by Lv Zheng <lv.zheng@intel.com>, Tested by Jung-uk Kim <jkim@freebsd.org>. Reported-by: John Baldwin <jhb@freebsd.org> Tested-by: Jung-uk Kim <jkim@freebsd.org> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
|
Hi, Patches in this pull request are all in Linux upstream. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 issues are detected by coverity unit tests.