Acpica trivial #200
Closed
Acpica trivial #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is reported by CoverityScan tool that AcpiPsGetNextArg() contains a potential memory leak problem in AcpiPsGetNextArg() when FIELDLIST is parsed (Link #1). This patch fixes this issue by introducing a concept of a specific type of argument which can contain variable number of elements. By doing so, this patch also sorts the order of the fields. Now fields are stored in the parser in the same order as they appear in the AML. Instead of cleaning up ArgCount (which was designed for the same purpose, but used as the indicator of initiating a new stacked parser state), this patch introduces VarArgs to support the arguments that can contain variable number of elements. Link: https://bugs.acpica.org/show_bug.cgi?id=1335 [#1] Reported-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
zetalog
force-pushed
the
acpica-trivial
branch
from
eb756ff
to
959a70e
Compare
|
Re-instatiate this fix in pull request #213 in order to solve conflicts, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ 1335.
Recent trivial bug fixes.