Skip to content

Conversation

@lvjianmin-loongson
Copy link
Contributor

Some platforms support the PCIEXP_WAKE_STS bit in the PM1 Status register and the PCIEXP_WAKE_EN bit in the PM1 Enable register. But ACPI_FADT_PCI_EXPRESS_WAKE is not set in fixed feature flag of FADT, skip handling it during processing fixed events if no ACPI_FADT_PCI_EXPRESS_WAKE set.

Second, fixed pcie wakeup event should be enabled before entering sleep state just as GPEs with wakeup ability, or the system will be not waked up by pcie devices due to its disabled state, and it should be cleared on waking up so that the event is disabled at runtime (it is not a runtime event).

Fixes: 32d8757 ("Events: Support fixed pcie wake event")

Some platforms support the PCIEXP_WAKE_STS bit in the PM1 Status
register and the PCIEXP_WAKE_EN bit in the PM1 Enable register.
But ACPI_FADT_PCI_EXPRESS_WAKE is not set in fixed feature
flag of FADT, skip handling it during processing fixed events
if no ACPI_FADT_PCI_EXPRESS_WAKE set.

Second, fixed pcie wakeup event should be enabled before entering
sleep state just as GPEs with wakeup ability, or the system will be
not waked up by pcie devices due to its disabled state, and it
should be cleared on waking up so that the event is disabled at
runtime (it is not a runtime event).

Fixes: 32d8757 ("Events: Support fixed pcie wake event")
Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
@SaketADumbre
Copy link
Member

Hi Jianmin,
Has this PR been tested on Unix-like(or Linux) and Windows/MSVC environments? Would it also address the concerns/resolutions found in PR #818 that we were not sure how to proceed with? I believe the PCIe Wake fixed event enable and disable support was added by Loongson before, possible sometime last year (2022) or so. Thanks!

  • Saket Dumbre

@SaketADumbre
Copy link
Member

I believe it was PR #757 and upon discussing it, the Windows implementation of ACPI still permanently disables the PCIe wake (fixed) event enable/disable support, so you might want to add it there as well after approval from MSFT or ASWG/USWG (I am not sure exactly who or where though)


if (Event == ACPI_EVENT_PCIE_WAKE &&
!(AcpiGbl_FADT.Flags & ACPI_FADT_PCI_EXPRESS_WAKE)) {
return_ACPI_STATUS (AE_BAD_PARAMETER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if AE_BAD_PARAMETER is the best choice of a return value for this case.

I would use AE_SUPPORT.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, it seems that AE_SUPPORT is more better here and others in the patch, I'll change them.
Thanks!

@lvjianmin-loongson
Copy link
Contributor Author

lvjianmin-loongson commented Apr 13, 2023

Hi Jianmin, Has this PR been tested on Unix-like(or Linux) and Windows/MSVC environments? Would it also address the concerns/resolutions found in PR #818 that we were not sure how to proceed with? I believe the PCIe Wake fixed event enable and disable support was added by Loongson before, possible sometime last year (2022) or so. Thanks!

  • Saket Dumbre

Yes, it addressed issues mentioned in PR #818, and has been tested for many machines, please see
https://bugzilla.kernel.org/show_bug.cgi?id=217069

@lvjianmin-loongson
Copy link
Contributor Author

I believe it was PR #757 and upon discussing it, the Windows implementation of ACPI still permanently disables the PCIe wake (fixed) event enable/disable support, so you might want to add it there as well after approval from MSFT or ASWG/USWG (I am not sure exactly who or where though)

Ok, I think I can discuss it with ASWG first.
Thanks!

@rafaeljw
Copy link
Contributor

Some platforms support the PCIEXP_WAKE_STS bit in the PM1 Status register and the PCIEXP_WAKE_EN bit in the PM1 Enable register. But ACPI_FADT_PCI_EXPRESS_WAKE is not set in fixed feature flag of FADT, skip handling it during processing fixed events if no ACPI_FADT_PCI_EXPRESS_WAKE set.

Second, fixed pcie wakeup event should be enabled before entering sleep state just as GPEs with wakeup ability, or the system will be not waked up by pcie devices due to its disabled state, and it should be cleared on waking up so that the event is disabled at runtime (it is not a runtime event).

Fixes: 32d8757 ("Events: Support fixed pcie wake event")

Can you please send the corresponding Linux patch to linux-acpi@vger.kernel.org?

@lvjianmin-loongson
Copy link
Contributor Author

I believe it was PR #757 and upon discussing it, the Windows implementation of ACPI still permanently disables the PCIe wake (fixed) event enable/disable support, so you might want to add it there as well after approval from MSFT or ASWG/USWG (I am not sure exactly who or where though)

Ok, I think I can discuss it with ASWG first. Thanks!

I have disscussed it with ASWG, as described in ACPI spec 6.5,
4.8.3.1.1 PM1 Status Registers, some fixed hardware features such
as TMR, GBL, PWRBTN, SLPBTN and RTC, will raise an interrupt event
if related xx_EN and xx_STS are set. But PCIEXP_WAKE as one kind
of fixed hardware feature, which does not generate an SCI, and is
used only as a wake event.

So, for PCIEXP_WAKE, we don't have to handle it in SCI interrupt
and disable/enable during S3/S4 period.

@lvjianmin-loongson
Copy link
Contributor Author

Some platforms support the PCIEXP_WAKE_STS bit in the PM1 Status register and the PCIEXP_WAKE_EN bit in the PM1 Enable register. But ACPI_FADT_PCI_EXPRESS_WAKE is not set in fixed feature flag of FADT, skip handling it during processing fixed events if no ACPI_FADT_PCI_EXPRESS_WAKE set.
Second, fixed pcie wakeup event should be enabled before entering sleep state just as GPEs with wakeup ability, or the system will be not waked up by pcie devices due to its disabled state, and it should be cleared on waking up so that the event is disabled at runtime (it is not a runtime event).
Fixes: 32d8757 ("Events: Support fixed pcie wake event")

Can you please send the corresponding Linux patch to linux-acpi@vger.kernel.org?

As I replied above, should we provide a fixed patch or revert?

@rafaeljw
Copy link
Contributor

Some platforms support the PCIEXP_WAKE_STS bit in the PM1 Status register and the PCIEXP_WAKE_EN bit in the PM1 Enable register. But ACPI_FADT_PCI_EXPRESS_WAKE is not set in fixed feature flag of FADT, skip handling it during processing fixed events if no ACPI_FADT_PCI_EXPRESS_WAKE set.
Second, fixed pcie wakeup event should be enabled before entering sleep state just as GPEs with wakeup ability, or the system will be not waked up by pcie devices due to its disabled state, and it should be cleared on waking up so that the event is disabled at runtime (it is not a runtime event).
Fixes: 32d8757 ("Events: Support fixed pcie wake event")

Can you please send the corresponding Linux patch to linux-acpi@vger.kernel.org?

As I replied above, should we provide a fixed patch or revert?

Yes, please.

There is a functional regression on multiple systems because of this issue.

@lvjianmin-loongson
Copy link
Contributor Author

Some platforms support the PCIEXP_WAKE_STS bit in the PM1 Status register and the PCIEXP_WAKE_EN bit in the PM1 Enable register. But ACPI_FADT_PCI_EXPRESS_WAKE is not set in fixed feature flag of FADT, skip handling it during processing fixed events if no ACPI_FADT_PCI_EXPRESS_WAKE set.
Second, fixed pcie wakeup event should be enabled before entering sleep state just as GPEs with wakeup ability, or the system will be not waked up by pcie devices due to its disabled state, and it should be cleared on waking up so that the event is disabled at runtime (it is not a runtime event).
Fixes: 32d8757 ("Events: Support fixed pcie wake event")

Can you please send the corresponding Linux patch to linux-acpi@vger.kernel.org?

As I replied above, should we provide a fixed patch or revert?

Yes, please.

There is a functional regression on multiple systems because of this issue.

Should I(myself) to submit the reverted patch? to both linux and ACPICA?

torvalds added a commit to torvalds/linux that referenced this pull request Apr 21, 2023
This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 22, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 22, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 22, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 22, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 22, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 22, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 22, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 23, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 23, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 23, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 23, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 23, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 23, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 23, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 24, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
13r0ck pushed a commit to pop-os/linux that referenced this pull request Apr 24, 2023
This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
@lvjianmin-loongson
Copy link
Contributor Author

The patch in this PR has not been needed any more, so close it.

ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this pull request Apr 25, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this pull request Apr 26, 2023
commit 8e41e0a upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sileshn pushed a commit to sileshn/ubuntu-kernel-lunar that referenced this pull request Jun 18, 2023
BugLink: https://bugs.launchpad.net/bugs/2023929

commit 8e41e0a575664d26bb87e012c39435c4c3914ed9 upstream.

This reverts commit 5c62d5a.

This broke wake-on-lan for multiple people, and for much too long.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069
Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/
Link: acpica/acpica#866
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Bob Moore <robert.moore@intel.com>
Cc: stable@kernel.org # 6.2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants