Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ACSF module is not disabled via config #3372

Closed
lcatlett opened this issue Feb 6, 2019 · 3 comments
Closed

Ensure that ACSF module is not disabled via config #3372

lcatlett opened this issue Feb 6, 2019 · 3 comments

Comments

@lcatlett
Copy link
Contributor

lcatlett commented Feb 6, 2019

Recently the ACSF product team discovered that if the ACSF module is disable via config split in the middle of BLT site update and tasks, other downstream BLT tasks that use the site_name and other variables set early when bootstrapping Drupal in BLT's pre-sites-php hook are set to null. Since the drush cache config also uses this information to generate a unique directory name per-site, this can result in race conditoins and other erratic results when running blt drupal:upate on ACSF sites. There should be a better developer and user experience to prevent this from happening in both BLT and the ACSF module.

@mikemadison13
Copy link
Contributor

FYI @lcatlett i noticed something on this with config split recently as well. We can certainly try to enable acsf module (as we are with config split) but if core.extensions does not have this module turned on, the second we do a config import, it's going to get turned back off again.

We likely need to add some explicit debugging statements that WILL get printed in the ACSF deploy errors so we know that it's happening because ACSF module is disabled. Not sure we can actually "force" it to be enabled though given the way config import works.

@mikemadison13
Copy link
Contributor

mikemadison13 commented Feb 13, 2019

#3369 provides additional guidance for the failure in 10.x. It may need to be back ported to 9.2.x.

@danepowell
Copy link
Contributor

I agree that there's not an elegant way for BLT to enforce this, I think the best we can do is provide a helpful error as we do in #3369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants