-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acsf hooks deploy #2227
Acsf hooks deploy #2227
Conversation
…date hook on 01live environments by default.
scripts/cloud-hooks/functions.sh
Outdated
;; | ||
ode[[:digit:]]*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to remove the ode check here? Isn't this going to cause all deployments to ACE to install the site from scratch?
@@ -20,9 +20,13 @@ repo_url="$5" | |||
repo_type="$6" | |||
|
|||
|
|||
acsf_file="/mnt/files/$AH_SITE_GROUP.$AH_SITE_ENVIRONMENT/files-private/sites.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use the provided script variables here (i.e. $site.$target_env
), rather than environment variables, so that this script can be tested more easily.
settings/acsf/db-update/db-update.sh
Outdated
|
||
deployupdate="$blt deploy:update --define environment=$env --define drush.uri=$domain -v -y" | ||
|
||
$deployudpate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
For anyone like me wondering why updates were disabled in production ACSF environments: you should be able to replicate this behavior by making sure to only deploy tags to production (don't use branches in production), and when you deploy make sure to tell ACSF to run DB updates. Then the BLT db-update factory hook will fire and run your usual updates like configuration imports. |
Fixes #2003
Changes proposed: