Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acsf hooks deploy #2227

Merged
merged 6 commits into from
Dec 12, 2017
Merged

Acsf hooks deploy #2227

merged 6 commits into from
Dec 12, 2017

Conversation

lcatlett
Copy link
Contributor

Fixes #2003

Changes proposed:

  • running BLT updates via post-code-deploy hooks are no longer recommended for ACSF in favor of db-update which will ensure zero-downtime deployments.
  • post-code-update hooks should be disabled by default for the 01live environment until a permanent solutions is evaluated for production deployments running a branch on 01live

;;
ode[[:digit:]]*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to remove the ode check here? Isn't this going to cause all deployments to ACE to install the site from scratch?

@@ -20,9 +20,13 @@ repo_url="$5"
repo_type="$6"


acsf_file="/mnt/files/$AH_SITE_GROUP.$AH_SITE_ENVIRONMENT/files-private/sites.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use the provided script variables here (i.e. $site.$target_env), rather than environment variables, so that this script can be tested more easily.


deployupdate="$blt deploy:update --define environment=$env --define drush.uri=$domain -v -y"

$deployudpate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

@grasmash grasmash added the Enhancement A feature or feature request label Dec 12, 2017
@danepowell
Copy link
Contributor

For anyone like me wondering why updates were disabled in production ACSF environments: you should be able to replicate this behavior by making sure to only deploy tags to production (don't use branches in production), and when you deploy make sure to tell ACSF to run DB updates. Then the BLT db-update factory hook will fire and run your usual updates like configuration imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants