Fixes #3217 to provide acsf-init-verify as part of git hooks and blt …

[mikemadison13]

…validate.

Fixes #3217

Changes proposed:

(What are you proposing we change?)

• adds validate / acsf to template blt.yml
• adds a acsf-init-validate command to blt validate
• adds the acsf validation command to validate all WHEN acsf validation is enabled in blt.yml

Steps to verify the solution:

(How does someone verify that this does what you think does?)

1. update your blt.yml file to include:

validate:
  acsf: true

2. run either blt validate if 1 was done, you should see the output like:

Validating ACSF settings...
[Acquia\Blt\Robo\Tasks\DrushTask] Running /var/www/<project>/vendor/bin/drush @self --include=modules/contrib/acsf/acsf_init acsf-init-verify --no-interaction --ansi in /var/www/<project>/docroot
 [success] acsf-init required files ok

3. manually run blt tests:acsf:validate

Warning, should not be run on non-acsf projects (which is why it defaults to not running). 

 

[mikemadison13]

Outstanding question if it makes sense to do this as part of the pre-commit hook or not. It seems to me that just having the safety check in blt validate (so builds fail) is sufficient.

[mikemadison13]

Would love feedback by common ACSF users (@msherron, @danepowell, @lcatlett, @arknoll, etc.)

[danepowell]

I like the idea of this, primarily to solve the problem of accidentally updating the ACSF module and failing to re-run acsf-init.

I don't think a pre-commit hook is the logical place for this. pre-commit hooks should be reserved for checks for the most frequent problems like syntax errors and bad commit messages. Failing to run acsf-init is something that happens once or twice per project. Better to do that in travis and avoid slowing down commits any further.

[grasmash]

This seems like it's in the wrong place. The check should be in AllCommand.php. That way, people can still voluntarily tests:acsf:validate without needing to modify yaml.