Replace includes.php $data by (stable) global variable equivalent

[rmuit]

Fixes #3362

Changes proposed:

In factory-hooks/post-sites-php/includes.php, change the usage of $data['gardens_site_settings'] into $GLOBALS['gardens_site_settings'].

At the same time, remove the PHPCS indicator that was only added because $data was used in this file.

Reasons:

• The ACSF Connector module's sites.php, in their version .x-.52 has stopped using $data, along with several other variables.
• There was no indication that (non-Drupal specific) variables in the local namespace of sites.php could just be used. On the other hand, it is hopefully self evident that we will never just change the contents of the the global $gardens_site_settings variable without notification. A global variable is (explicitly meant to be) used in other places in the Drupal codebase.

Please note: since $GLOBALS['gardens_site_settings'] has 'always' existed, this should be backportable without any issue to every 9.x version. (This includes.php was introduced in an early alpha version of 9.x)

Steps to replicate the issue:

Can be found in a.o. [ internal tickets, known by lcatlett]. I hope you will forgive me for not having exact steps and not even reproducing the error.

But note that the issue means that includes.php does not define global $_acsf_site_name - I don't know BLT but from my viewpoint that can have any kind of effects.

Steps to verify the solution:

• Reproduce whatever issues those tickets (or any others that you know of) had.
• Notice that the PHP Notices about undefined $data and undefined indexes disappear.
• Run PHPCS (your own standards) on includes.php and check that there are no issues.

[lcatlett]

@rmuit - thank you for submitting this PR! could you please remove the internal ticket number DG-20990 and PF-1795 when you get a chance?

[rmuit]

Removed.

[mikemadison13]

@rmuit thank you so much for this!

am i reading you correctly that this will only work with ACSF version 2.52? perhaps we should update composer to force that version or higher as part of this PR as well if so?

[rmuit]

Nope. I should have said this more clearly, but "since $GLOBALS['gardens_site_settings'] has 'always' existed,"

• it is not only backportable to BLT 9.x
• but also it works with 'every' past ACSF versions (at least years back)

[mikemadison13]

oh awesome. glad i asked then! thanks

[mikemadison13]

this definitely fixes the missing "$data" warnings I was seeing recently in factory hook output. so that's a good sign.