Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3615 to remove sensiolabs-de/deprecation-detector. #3621

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
3 participants
@mikemadison13
Copy link
Collaborator

commented May 3, 2019

Fixes #3615

Changes proposed

(What are you proposing we change? How does this impact end users? Are manual or automatic updates required?)

  • removes sensiolabs-de/deprecation-detector from composer.required
  • removes deprecation scans from tests and validation
@mikemadison13

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2019

@danepowell we should hold on merging this until the Beta of the module drops.

@JDDoesDev

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

There's also an issue that this command is being used in vendor/acquia/blt/src/Robo/Commands/Validate/DeprecatedCommand.php so there should probably be some changes to that code to make sure there's a replacement command.

@JDDoesDev

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

For anyone ending up here, I've documented a workaround.

https://www.jamesdflynn.com/development/drupal-check-site-factory-and-acquia-blt-oh-my

@mikemadison13 mikemadison13 force-pushed the mikemadison13:3615 branch from 7733d00 to d00698e May 9, 2019

@mikemadison13

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2019

removed upgrade status from this, also removed the deprecated command as well as the library

@danepowell danepowell merged commit 50a880e into acquia:9.2.x May 10, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.