Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

Removing (seemingly) unnecessary dependency on ruby 1.9.3. #5

Closed
wants to merge 1 commit into from
Closed

Conversation

someara
Copy link
Contributor

@someara someara commented Dec 14, 2011

Opscode will be shipping ruby 1.9.2 embedded in it's omnibus builds for both client and server. This gem is awesome and crazy useful, and should be compatible with mainline chef's environment

…ll be shipping ruby 1.9.2 embedded in it's omnibus builds for both client and server. This gem is awesome and crazy useful, and should be compatible with mainline chef's environment
acrmp pushed a commit that referenced this pull request Dec 14, 2011
acrmp pushed a commit that referenced this pull request Dec 14, 2011
@acrmp
Copy link
Member

acrmp commented Dec 14, 2011

Hi Sean,

Good call - omnibus compatibility will definitely be the way to go.

The ruby version constraint was there because Ripper (included in the stdlib) was supposed to have had a bunch of bugfixes introduced in 1.9.3.

The features are all green on 1.9.2 though so this looks cool to relax. I'm going to make it 1.9.2+ although with ripper18 in theory we could make it run on the 1.8 series too.

I've pushed it to rubygems as foodcritic 0.5.1.

Thanks!

Andrew.

@acrmp acrmp closed this Dec 14, 2011
@someara
Copy link
Contributor Author

someara commented Dec 14, 2011

Awesome! thanks!

-s

On Wed, Dec 14, 2011 at 5:04 PM, Andrew Crump
reply@reply.github.com
wrote:

Hi Sean,

Good call - omnibus compatibility will definitely be the way to go.

The ruby version constraint was there because Ripper (included in the stdlib) was supposed to have had a bunch of bugfixes introduced in 1.9.3.

The features are all green on 1.9.2 though so this looks cool to relax. I'm going to make it 1.9.2+ although with ripper18 in theory we could make it run on the 1.8 series too.

I've pushed it to rubygems as foodcritic 0.5.1.

Thanks!

Andrew.


Reply to this email directly or view it on GitHub:
#5 (comment)

acrmp pushed a commit that referenced this pull request Dec 14, 2011
acrmp pushed a commit that referenced this pull request Dec 21, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants