Skip to content
This repository


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Remove unnecessary code in Kafka::Producer#batch #17

wants to merge 1 commit into from

1 participant


This pull request removes unnecessary code in Kafka::Producer#batch method. Since the method always creates a new Kafka::Batch instance at the beginning, it would not be necessary to clear its instance variable batch.messages at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jan 24, 2013
bitterb bitterb Remove unnecessary code in Kafka::Producer#batch 918d215
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 0 additions and 1 deletion. Show diff stats Hide diff stats

  1. +0 1  lib/kafka/producer.rb
1  lib/kafka/producer.rb
@@ -36,7 +36,6 @@ def batch(&block)
36 36 batch =
37 37 batch )
38 38 self.send(batch.messages)
39   - batch.messages.clear
40 39 end
41 40 end
42 41 end

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.