From 892f6bd073234fcbd579c140b7ac636a0edf4f1a Mon Sep 17 00:00:00 2001 From: chrismaree Date: Wed, 16 Mar 2022 07:42:51 +0200 Subject: [PATCH 1/2] fix[N03] Fixed inconsistant token metadata versioning Signed-off-by: chrismaree --- contracts/LpTokenFactory.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/LpTokenFactory.sol b/contracts/LpTokenFactory.sol index 5ae5f6dbc..9ac510877 100644 --- a/contracts/LpTokenFactory.sol +++ b/contracts/LpTokenFactory.sol @@ -17,7 +17,7 @@ contract LpTokenFactory is LpTokenFactoryInterface { */ function createLpToken(address l1Token) public returns (address) { ExpandedERC20 lpToken = new ExpandedERC20( - _append("Across ", IERC20Metadata(l1Token).name(), " LP Token"), // LP Token Name + _append("Across V2 ", IERC20Metadata(l1Token).name(), " LP Token"), // LP Token Name _append("Av2-", IERC20Metadata(l1Token).symbol(), "-LP"), // LP Token Symbol IERC20Metadata(l1Token).decimals() // LP Token Decimals ); From 91a08a9bd2b47a1a1319aff8bda53349e8264ce3 Mon Sep 17 00:00:00 2001 From: chrismaree Date: Wed, 16 Mar 2022 08:42:03 +0200 Subject: [PATCH 2/2] nit Signed-off-by: chrismaree --- test/HubPool.Admin.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/HubPool.Admin.ts b/test/HubPool.Admin.ts index 107ac60be..05312e804 100644 --- a/test/HubPool.Admin.ts +++ b/test/HubPool.Admin.ts @@ -30,7 +30,7 @@ describe("HubPool Admin functions", function () { const lpToken = await (await getContractFactory("ExpandedERC20", owner)).attach(pooledTokenStruct.lpToken); expect(await lpToken.callStatic.symbol()).to.equal("Av2-WETH-LP"); - expect(await lpToken.callStatic.name()).to.equal("Across Wrapped Ether LP Token"); + expect(await lpToken.callStatic.name()).to.equal("Across V2 Wrapped Ether LP Token"); }); it("Only owner can enable L1 Tokens for liquidity provision", async function () { await expect(hubPool.connect(other).enableL1TokenForLiquidityProvision(weth.address)).to.be.reverted;