From 7bc27e1c151189dc325412201d4349fa06373ee3 Mon Sep 17 00:00:00 2001 From: chrismaree Date: Wed, 16 Mar 2022 08:06:03 +0200 Subject: [PATCH 1/2] fix[N04] Remove LPTokenFactory Magic numbers Signed-off-by: chrismaree --- contracts/LpTokenFactory.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/LpTokenFactory.sol b/contracts/LpTokenFactory.sol index 5ae5f6dbc..d66f9739e 100644 --- a/contracts/LpTokenFactory.sol +++ b/contracts/LpTokenFactory.sol @@ -21,8 +21,8 @@ contract LpTokenFactory is LpTokenFactoryInterface { _append("Av2-", IERC20Metadata(l1Token).symbol(), "-LP"), // LP Token Symbol IERC20Metadata(l1Token).decimals() // LP Token Decimals ); - lpToken.addMember(1, msg.sender); // Set this contract as the LP Token's minter. - lpToken.addMember(2, msg.sender); // Set this contract as the LP Token's burner. + lpToken.addMinter(msg.sender); // Set the caller as the LP Token's minter. + lpToken.addMinter(msg.sender); // Set the caller as the LP Token's burner. return address(lpToken); } From ec72f3b75746e2cad1aec51b5ed4194362a6e7e3 Mon Sep 17 00:00:00 2001 From: chrismaree Date: Wed, 16 Mar 2022 08:08:04 +0200 Subject: [PATCH 2/2] fix[N04] Remove LPTokenFactory Magic numbers Signed-off-by: chrismaree --- contracts/LpTokenFactory.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/LpTokenFactory.sol b/contracts/LpTokenFactory.sol index d66f9739e..50ffd2150 100644 --- a/contracts/LpTokenFactory.sol +++ b/contracts/LpTokenFactory.sol @@ -22,7 +22,7 @@ contract LpTokenFactory is LpTokenFactoryInterface { IERC20Metadata(l1Token).decimals() // LP Token Decimals ); lpToken.addMinter(msg.sender); // Set the caller as the LP Token's minter. - lpToken.addMinter(msg.sender); // Set the caller as the LP Token's burner. + lpToken.addBurner(msg.sender); // Set the caller as the LP Token's burner. return address(lpToken); }