feat(svm): fill tests with codama and solana kit #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
requested review from
Reinis-FRP,
chrismaree,
mrice32 and
nicholaspai
as code owners
Reinis-FRP
reviewed
Mar 17, 2025
| @@ -1,31 +1,49 @@ | |||
| import * as anchor from "@coral-xyz/anchor"; | |||
| import { BN, web3 } from "@coral-xyz/anchor"; | |||
| import { getApproveCheckedInstruction } from "@solana-program/token"; | |||
There was a problem hiding this comment.
add this to package.json
Reinis-FRP
reviewed
Mar 17, 2025
test/svm/SvmSpoke.Fill.ts
Outdated
| program: address(program.programId.toString()), | ||
| eventAuthority, | ||
| signer, | ||
| remainingAccounts: fillRemainingAccounts, |
There was a problem hiding this comment.
this is not in FillRelayAsyncInput props
There was a problem hiding this comment.
You are right, remaining accounts are passed here:
contracts/test/svm/SvmSpoke.Fill.ts
Lines 726 to 730 in 583d129
And I forgot to remove it from this obj.
Reinis-FRP
reviewed
Mar 17, 2025
test/svm/SvmSpoke.Fill.ts
Outdated
Comment on lines
722
to
723
| ...(await SvmSpokeClient.getFillRelayInstructionAsync(fillRelayInput)), | ||
| accounts: (await SvmSpokeClient.getFillRelayInstructionAsync(fillRelayInput)).accounts.map((account) => |
There was a problem hiding this comment.
would we better have single call to getFillRelayInstructionAsync and store result in a variable rather than call it twice here
…-codama-equivalence-in-fill-tests
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Reinis-FRP
approved these changes
Mar 28, 2025
md0x
deleted the
pablo/acx-3906-validate-solana-web3-v2-kit-codama-equivalence-in-fill-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: