fix: pass integratorId to swap API #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
gsteenkamp89
requested review from
amateima,
ashwinrava,
dohaki,
melisaguevara,
mrice32 and
nicholaspai
as code owners
🦋 Changeset detectedLatest commit: 6a91bb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
gsteenkamp89
commented
Sep 24, 2025
Comment on lines
+27
to
+36
| const integratorIdSuffix = getIntegratorDataSuffix(integratorId); | ||
| const swapSuffix = SWAP_CALLDATA_MARKER; | ||
| // swap/approval first appends the integratorId, then the swap marker | ||
| const suffix = options.isSwap | ||
| ? concat([integratorIdSuffix, swapSuffix]) | ||
| : integratorIdSuffix; | ||
|
|
||
| return calldata.endsWith(suffix.slice(2)); | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
is it safe to rather check calldata.includes(integratorIdSuffix.slice(2)) ?
Member
There was a problem hiding this comment.
Hmm, both work but I think we can keep it as is since we use .concat on the swap marker after the integrator id as you mentioned.
ashwinrava
approved these changes
Sep 24, 2025
gsteenkamp89
deleted the
fix/gsteenkamp-append-integratorid-swap-calldata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ACP-5
problem
getSwapQuotedoes not accept theintegratorIDparam and thus does not pass it to the swap API.Work done
integratorIDas param and passes it to swap api to be appended to calldata.