New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 9.0 add cmis web proxy #4

Closed
wants to merge 34 commits into
base: 9.0
from

Conversation

Projects
None yet
2 participants
@lmignon
Member

lmignon commented Sep 10, 2016

No description provided.

@lmignon lmignon added the WIP label Sep 10, 2016

@lmignon lmignon changed the title from 9.0 add cmis web proxy to WIP 9.0 add cmis web proxy Sep 10, 2016

if token:
token = token.replace('Bearer', '').strip()
else:
token = params.get('token').strip()

This comment has been minimized.

@sbidoul

sbidoul Sep 13, 2016

Member

@lmignon params.get('token') may be None => stack trace

    token = params.get('token').strip()
AttributeError: 'NoneType' object has no attribute 'strip'
@sbidoul

sbidoul Sep 13, 2016

Member

@lmignon params.get('token') may be None => stack trace

    token = params.get('token').strip()
AttributeError: 'NoneType' object has no attribute 'strip'

This comment has been minimized.

@lmignon

lmignon Sep 14, 2016

Member

@sbidoul You're right. Moreover, the logic here is suspicious. The fact that you have this error reveals that the logic is called whereas the apply_odoo_security is False. By looking deeper into the code, I've found a place where I call this method without checking to 'apply_odoo_security` https://github.com/acsone/alfodoo/blob/9.0-add-cmis_web_proxy/cmis_web_proxy_alf/controllers/alfresco.py#L40. I must to also change this method.

@lmignon

lmignon Sep 14, 2016

Member

@sbidoul You're right. Moreover, the logic here is suspicious. The fact that you have this error reveals that the logic is called whereas the apply_odoo_security is False. By looking deeper into the code, I've found a place where I call this method without checking to 'apply_odoo_security` https://github.com/acsone/alfodoo/blob/9.0-add-cmis_web_proxy/cmis_web_proxy_alf/controllers/alfresco.py#L40. I must to also change this method.

lmignon and others added some commits Aug 2, 2016

Fix field definition into ir_model_fields
Patch BaseModel._field_create to take into account the 'ttype' attribute defined on the field class as value for the ttype comlumn in the ir_model_fields table in place of the 'type' attribute
@@ -7,7 +7,7 @@
'version': '9.0.1.0.0',
'category': 'Connector',
'summary': 'Alfresco extension for the CMIS Connector',
'author': "ACSONE SA/NV Community Association (OCA)",
'author': "ACSONE SA/NV",
'website': 'https://odoo-community.org/',

This comment has been minimized.

@sbidoul

sbidoul Sep 28, 2016

Member

@lmignon website: acsone.eu for the moment

@sbidoul

sbidoul Sep 28, 2016

Member

@lmignon website: acsone.eu for the moment

@lmignon

This comment has been minimized.

Show comment
Hide comment
@lmignon
Member

lmignon commented Oct 10, 2016

@lmignon lmignon closed this Oct 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment