WIP 9.0 add cmis web proxy #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if token: | ||
| token = token.replace('Bearer', '').strip() | ||
| else: | ||
| token = params.get('token').strip() |
There was a problem hiding this comment.
@lmignon params.get('token') may be None => stack trace
token = params.get('token').strip()
AttributeError: 'NoneType' object has no attribute 'strip'
There was a problem hiding this comment.
@sbidoul You're right. Moreover, the logic here is suspicious. The fact that you have this error reveals that the logic is called whereas the apply_odoo_security is False. By looking deeper into the code, I've found a place where I call this method without checking to 'apply_odoo_security` https://github.com/acsone/alfodoo/blob/9.0-add-cmis_web_proxy/cmis_web_proxy_alf/controllers/alfresco.py#L40. I must to also change this method.
lmignon
force-pushed
the
9.0-add-cmis_web_proxy
branch
from
387a4f3 to
5749a11
Compare
Patch BaseModel._field_create to take into account the 'ttype' attribute defined on the field class as value for the ttype comlumn in the ir_model_fields table in place of the 'type' attribute
sbidoul
reviewed
Sep 28, 2016
| @@ -7,7 +7,7 @@ | |||
| 'version': '9.0.1.0.0', | |||
| 'category': 'Connector', | |||
| 'summary': 'Alfresco extension for the CMIS Connector', | |||
| 'author': "ACSONE SA/NV Community Association (OCA)", | |||
| 'author': "ACSONE SA/NV", | |||
| 'website': 'https://odoo-community.org/', | |||
There was a problem hiding this comment.
@lmignon website: acsone.eu for the moment
|
dev moved to https://github.com/acsone/alfodoo-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.