Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 9.0 add cmis web proxy #4

Closed
wants to merge 34 commits into from
Closed

WIP 9.0 add cmis web proxy #4

wants to merge 34 commits into from

Conversation

lmignon
Copy link
Member

@lmignon lmignon commented Sep 10, 2016

No description provided.

@lmignon lmignon added the WIP label Sep 10, 2016
@lmignon lmignon changed the title 9.0 add cmis web proxy WIP 9.0 add cmis web proxy Sep 10, 2016
if token:
token = token.replace('Bearer', '').strip()
else:
token = params.get('token').strip()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmignon params.get('token') may be None => stack trace

    token = params.get('token').strip()
AttributeError: 'NoneType' object has no attribute 'strip'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbidoul You're right. Moreover, the logic here is suspicious. The fact that you have this error reveals that the logic is called whereas the apply_odoo_security is False. By looking deeper into the code, I've found a place where I call this method without checking to 'apply_odoo_security` https://github.com/acsone/alfodoo/blob/9.0-add-cmis_web_proxy/cmis_web_proxy_alf/controllers/alfresco.py#L40. I must to also change this method.

@lmignon lmignon force-pushed the 9.0-add-cmis_web_proxy branch from 387a4f3 to 5749a11 Compare Sep 14, 2016
lmignon and others added 6 commits Sep 14, 2016
Patch BaseModel._field_create to take into account the 'ttype' attribute defined on the field class as value for the ttype comlumn in the ir_model_fields table in place of the 'type' attribute
@@ -7,7 +7,7 @@
'version': '9.0.1.0.0',
'category': 'Connector',
'summary': 'Alfresco extension for the CMIS Connector',
'author': "ACSONE SA/NV Community Association (OCA)",
'author': "ACSONE SA/NV",
'website': 'https://odoo-community.org/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmignon website: acsone.eu for the moment

@lmignon
Copy link
Member Author

lmignon commented Oct 10, 2016

dev moved to https://github.com/acsone/alfodoo-dev

@lmignon lmignon closed this Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants